r67844 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67843‎ | r67844 | r67845 >
Date:07:47, 11 June 2010
Author:aaron
Status:deferred
Tags:
Comment:
Added more TODOs
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -140,6 +140,7 @@
141141 /**
142142 * Should this be using a simple icon-based UI?
143143 * Check the user's preferences first, using the site settings as the default.
 144+ * @TODO: dependency inject the User?
144145 * @returns bool
145146 */
146147 public static function useSimpleUI() {
@@ -212,6 +213,7 @@
213214
214215 /**
215216 * Should this user ignore the site and page default version settings?
 217+ * @TODO: dependency inject the User?
216218 * @returns bool
217219 */
218220 public static function ignoreDefaultVersion() {
@@ -411,6 +413,7 @@
412414 * @param string $tag
413415 * @param int $value
414416 * @returns bool
 417+ * @TODO: dependency inject the User?
415418 */
416419 public static function userCanSetTag( $tag, $value ) {
417420 global $wgUser;
@@ -446,6 +449,7 @@
447450 * @param array $flags, suggested flags
448451 * @param array $oldflags, pre-existing flags
449452 * @returns bool
 453+ * @TODO: dependency inject the User?
450454 */
451455 public static function userCanSetFlags( $flags, $oldflags = array() ) {
452456 global $wgUser;
@@ -472,6 +476,7 @@
473477 * Check if a user can set the autoreview restiction level to $right
474478 * @param string $right the level
475479 * @returns bool
 480+ * @TODO: dependency inject the User?
476481 */
477482 public static function userCanSetAutoreviewLevel( $right ) {
478483 global $wgUser;

Status & tagging log