r67823 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r67822‎ | r67823 | r67824 >
Date:15:37, 10 June 2010
Author:ialex
Status:ok
Tags:
Comment:
* Fix for r67185: cache the page if caching is allowed, not the opposite :)
* also removed useless check for $this (can this ever be false?)
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
——@@ -4458,7 +4458,7 @@
44594459 $this->mTitle->getPrefixedDBkey() ) );
44604460 }
44614461
4462 - if ( $wgEnableParserCache && $cache && $this && !$this->mParserOutput->isCacheable() ) {
 4462+ if ( $wgEnableParserCache && $cache && $this->mParserOutput->isCacheable() ) {
44634463 $parserCache = ParserCache::singleton();
44644464 $parserCache->save( $this->mParserOutput, $this, $parserOptions );
44654465 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67185allow parser/extensions to control for how long a ParserOutput gets cached. I...daniel14:28, 1 June 2010

Status & tagging log