r67727 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67726‎ | r67727 | r67728 >
Date:15:06, 9 June 2010
Author:demon
Status:ok
Tags:
Comment:
Followup r67707, cast these to boolean just to be paranoid
Modified paths:
  • /trunk/phase3/includes/ImageGallery.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImageGallery.php
@@ -183,7 +183,7 @@
184184 * @param $f Boolean: set to false to disable.
185185 */
186186 function setShowBytes( $f ) {
187 - $this->mShowBytes = $f;
 187+ $this->mShowBytes = (bool)$f;
188188 }
189189
190190 /**
@@ -193,7 +193,7 @@
194194 * @param $f Boolean: set to false to disable.
195195 */
196196 function setShowFilename( $f ) {
197 - $this->mShowFilename = $f;
 197+ $this->mShowFilename = (bool)$f;
198198 }
199199
200200 /**

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67707Fixed a bunch of silly instances of [^!=]==\s*(true|false)demon11:44, 9 June 2010

Status & tagging log