r67666 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67665‎ | r67666 | r67667 >
Date:20:32, 8 June 2010
Author:platonides
Status:ok
Tags:
Comment:
Move icons footer into $footerlinks. A couple of ids which weren't used anywhere get slightly renamed.
Modified paths:
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
@@ -439,7 +439,15 @@
440440 'about',
441441 'disclaimer',
442442 ),
 443+ 'icons' => array(
 444+ 'poweredbyico',
 445+ 'copyrightico',
 446+ ),
443447 );
 448+ $footerlinksClasses = array(
 449+ 'icons' => array( 'noprint' )
 450+ );
 451+
444452 // Reduce footer links down to only those which are being used
445453 $validFooterLinks = array();
446454 foreach( $footerlinks as $category => $links ) {
@@ -543,7 +551,7 @@
544552 <div id="footer"<?php $this->html('userlangattributes') ?>>
545553 <?php foreach( $validFooterLinks as $category => $links ): ?>
546554 <?php if ( count( $links ) > 0 ): ?>
547 - <ul id="footer-<?php echo $category ?>">
 555+ <ul id="footer-<?php echo $category ?>"<?php if (isset($footerlinksClasses[$category])) echo ' class="' . implode(" ", $footerlinksClasses[$category]) . '"'; ?>>
548556 <?php foreach( $links as $link ): ?>
549557 <?php if( isset( $this->data[$link] ) && $this->data[$link] ): ?>
550558 <li id="footer-<?php echo $category ?>-<?php echo $link ?>"><?php $this->html( $link ) ?></li>
@@ -552,14 +560,6 @@
553561 </ul>
554562 <?php endif; ?>
555563 <?php endforeach; ?>
556 - <ul id="footer-icons" class="noprint">
557 - <?php if ( $this->data['poweredbyico'] ): ?>
558 - <li id="footer-icon-poweredby"><?php $this->html( 'poweredbyico' ) ?></li>
559 - <?php endif; ?>
560 - <?php if ( $this->data['copyrightico'] ): ?>
561 - <li id="footer-icon-copyright"><?php $this->html( 'copyrightico' ) ?></li>
562 - <?php endif; ?>
563 - </ul>
564564 <div style="clear:both"></div>
565565 </div>
566566 <!-- /footer -->

Status & tagging log