r67568 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67567‎ | r67568 | r67569 >
Date:22:00, 7 June 2010
Author:catrope
Status:deferred (Comments)
Tags:
Comment:
1.16wmf4: Merge r67281 (show language links by default in CollapsibleNav) from trunk. Revision is currently reverted on trunk, but that will be undone shortly
Modified paths:
  • /branches/wmf/1.16wmf4/extensions/UsabilityInitiative (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/UsabilityInitiative/Vector/Modules/CollapsibleNav/CollapsibleNav.js (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/UsabilityInitiative/Vector/Vector.combined.js (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/UsabilityInitiative/Vector/Vector.combined.min.js (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/extensions/UsabilityInitiative/Vector/Modules/CollapsibleNav/CollapsibleNav.js
@@ -40,7 +40,7 @@
4141 $j( '#panel > div.portal:not(:first)' )
4242 .each( function( i ) {
4343 var state = $j.cookie( 'vector-nav-' + $j(this).attr( 'id' ) );
44 - if ( state == 'true' || ( state == null && i < 1 ) ) {
 44+ if ( state == 'true' || ( state == null && (i < 1 || ( $j(this).attr( 'id' ) == 'p-lang' ) ) ) ) {
4545 $j(this)
4646 .addClass( 'expanded' )
4747 .find( 'div.body' )
Index: branches/wmf/1.16wmf4/extensions/UsabilityInitiative/Vector/Vector.combined.js
@@ -40,7 +40,7 @@
4141 $j( '#panel > div.portal:not(:first)' )
4242 .each( function( i ) {
4343 var state = $j.cookie( 'vector-nav-' + $j(this).attr( 'id' ) );
44 - if ( state == 'true' || ( state == null && i < 1 ) ) {
 44+ if ( state == 'true' || ( state == null && (i < 1 || ( $j(this).attr( 'id' ) == 'p-lang' ) ) ) ) {
4545 $j(this)
4646 .addClass( 'expanded' )
4747 .find( 'div.body' )
Index: branches/wmf/1.16wmf4/extensions/UsabilityInitiative/Vector/Vector.combined.min.js
@@ -1,7 +1,7 @@
22
33 $j(document).ready(function(){if(!wgVectorEnabledModules.collapsiblenav){return true;}
44 var mod={'browsers':{'ltr':{'opera':[['>=',9.6]],'konqueror':[['>=',4.0]],'blackberry':false,'ipod':false,'iphone':false},'rtl':{'opera':[['>=',9.6]],'konqueror':[['>=',4.0]],'blackberry':false,'ipod':false,'iphone':false}}};if(!$j.wikiEditor.isSupported(mod)){return true;}
5 -$j('#panel').addClass('collapsible-nav');$j('#panel > div.portal:first').addClass('expanded').find('div.body').show();$j('#panel > div.portal:not(:first)').each(function(i){var state=$j.cookie('vector-nav-'+$j(this).attr('id'));if(state=='true'||(state==null&&i<1)){$j(this).addClass('expanded').find('div.body').show();}else{$j(this).addClass('collapsed');}
 5+$j('#panel').addClass('collapsible-nav');$j('#panel > div.portal:first').addClass('expanded').find('div.body').show();$j('#panel > div.portal:not(:first)').each(function(i){var state=$j.cookie('vector-nav-'+$j(this).attr('id'));if(state=='true'||(state==null&&(i<1||($j(this).attr('id')=='p-lang')))){$j(this).addClass('expanded').find('div.body').show();}else{$j(this).addClass('collapsed');}
66 if(state!=null){$j.cookie('vector-nav-'+$j(this).attr('id'),state,{expires:30,path:'/'});}});function toggle($element){$j.cookie('vector-nav-'+$element.parent().attr('id'),$element.parent().is('.collapsed'),{expires:30,path:'/'});$element.parent().toggleClass('expanded').toggleClass('collapsed').find('div.body').slideToggle('fast');}
77 var $headings=$j('#panel > div.portal > h5');var maxTI=0;$j('[tabindex]').each(function(){var ti=parseInt($j(this).attr('tabindex'));if(ti>maxTI)
88 maxTI=ti;});var tabIndex=maxTI+1;$j('#searchInput').attr('tabindex',tabIndex++);$headings.each(function(){$j(this).attr('tabindex',tabIndex++);});$headings.keydown(function(event){if(event.which==13||event.which==32){toggle($j(this));}}).mousedown(function(){toggle($j(this));$j(this).blur();return false;});});$j(document).ready(function(){if(!wgVectorEnabledModules.collapsibletabs){return true;}
Property changes on: branches/wmf/1.16wmf4/extensions/UsabilityInitiative
___________________________________________________________________
Modified: svn:mergeinfo
99 Merged /trunk/extensions/UsabilityInitiative:r67281

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67281Do not collapse interwikis by default....platonides16:22, 3 June 2010

Comments

#Comment by TheDJ (talk | contribs)   09:55, 20 June 2010

Seems that collapse state of languages (cookie) is not adhered to when determining state of "other languages" tab.

#Comment by Catrope (talk | contribs)   19:55, 29 June 2010

Resetting commit state to new. Problem is with the original rev (which was also marked as fixme), not with the merge.

Status & tagging log