r67564 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67563‎ | r67564 | r67565 >
Date:20:54, 7 June 2010
Author:adam
Status:resolved (Comments)
Tags:
Comment:
Followup to r67539. Applying the float only if expandable search is enabled
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Modules/ExpandableSearch/ExpandableSearch.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.combined.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.min.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/vector.expandableSearch.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/css/vector.expandableSearch.css
@@ -7,5 +7,4 @@
88 }
99 div#simpleSearch button#searchButton {
1010 margin: 0.4em 0 0 0;
11 - float: right;
1211 }
Index: trunk/extensions/UsabilityInitiative/css/combined.css
@@ -141,7 +141,6 @@
142142 }
143143 div#simpleSearch button#searchButton {
144144 margin: 0.4em 0 0 0;
145 - float: right;
146145 }
147146 /* wikiEditor plugin */
148147
Index: trunk/extensions/UsabilityInitiative/css/combined.min.css
@@ -139,7 +139,6 @@
140140 }
141141 div#simpleSearch button#searchButton{
142142 margin:0.4em 0 0 0;
143 -float:right;
144143 }
145144 form#editform{
146145 margin:0;
Index: trunk/extensions/UsabilityInitiative/Vector/Modules/ExpandableSearch/ExpandableSearch.js
@@ -39,5 +39,7 @@
4040 $j.collapsibleTabs.handleResize();
4141 }
4242 }
43 - } );
 43+ } )
 44+ .siblings( 'button' )
 45+ .css( 'float', 'right' );
4446 });
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.hooks.php
@@ -14,16 +14,16 @@
1515 'raw' => array(
1616 array( 'src' => 'Modules/CollapsibleNav/CollapsibleNav.js', 'version' => 18 ),
1717 array( 'src' => 'Modules/CollapsibleTabs/CollapsibleTabs.js', 'version' => 8 ),
18 - array( 'src' => 'Modules/ExpandableSearch/ExpandableSearch.js', 'version' => 2 ),
 18+ array( 'src' => 'Modules/ExpandableSearch/ExpandableSearch.js', 'version' => 3 ),
1919 array( 'src' => 'Modules/EditWarning/EditWarning.js', 'version' => 8 ),
2020 array( 'src' => 'Modules/FooterCleanup/FooterCleanup.js', 'version' => 5 ),
2121 array( 'src' => 'Modules/SimpleSearch/SimpleSearch.js', 'version' => 15 ),
2222 ),
2323 'combined' => array(
24 - array( 'src' => 'Vector.combined.js', 'version' => 40 ),
 24+ array( 'src' => 'Vector.combined.js', 'version' => 41 ),
2525 ),
2626 'minified' => array(
27 - array( 'src' => 'Vector.combined.min.js', 'version' => 40 ),
 27+ array( 'src' => 'Vector.combined.min.js', 'version' => 41 ),
2828 ),
2929 );
3030 static $modules = array(
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.combined.js
@@ -375,7 +375,9 @@
376376 $j.collapsibleTabs.handleResize();
377377 }
378378 }
379 - } );
 379+ } )
 380+ .siblings( 'button' )
 381+ .css( 'float', 'right' );
380382 });
381383 /* Prototype code to demonstrate proposed edit page footer cleanups */
382384 /* First draft and will be changing greatly */
Index: trunk/extensions/UsabilityInitiative/Vector/Vector.combined.min.js
@@ -20,7 +20,7 @@
2121 if(fallbackResult!==undefined){return fallbackResult;}
2222 if(wgAction=='submit'||$j('#wpTextbox1').data('origtext')!=$j('#wpTextbox1').val()||$j('#wpSummary').data('origtext')!=$j('#wpSummary').val()){return mw.usability.getMsg('vector-editwarning-warning');}}
2323 $j('form').submit(function(){window.onbeforeunload=fallbackWindowOnBeforeUnload;});});var fallbackWindowOnBeforeUnload=null;$j(document).ready(function(){if(!wgVectorEnabledModules.expandablesearch||skin!='vector'){return true;}
24 -$j('#searchInput').expandableField({'beforeExpand':function(context){$j(this).parent().animate({'borderTopColor':'#a0d8ff','borderLeftColor':'#a0d8ff','borderRightColor':'#a0d8ff','borderBottomColor':'#a0d8ff'},'fast');},'beforeCondense':function(context){$j(this).parent().animate({'borderTopColor':'#aaaaaa','borderLeftColor':'#aaaaaa','borderRightColor':'#aaaaaa','borderBottomColor':'#aaaaaa'},'fast');},'afterExpand':function(context){if(typeof $j.collapsibleTabs!='undefined'){$j.collapsibleTabs.handleResize();}},'afterCondense':function(context){if(typeof $j.collapsibleTabs!='undefined'){$j.collapsibleTabs.handleResize();}}});});$j(document).ready(function(){if(!wgVectorEnabledModules.footercleanup){return true;}
 24+$j('#searchInput').expandableField({'beforeExpand':function(context){$j(this).parent().animate({'borderTopColor':'#a0d8ff','borderLeftColor':'#a0d8ff','borderRightColor':'#a0d8ff','borderBottomColor':'#a0d8ff'},'fast');},'beforeCondense':function(context){$j(this).parent().animate({'borderTopColor':'#aaaaaa','borderLeftColor':'#aaaaaa','borderRightColor':'#aaaaaa','borderBottomColor':'#aaaaaa'},'fast');},'afterExpand':function(context){if(typeof $j.collapsibleTabs!='undefined'){$j.collapsibleTabs.handleResize();}},'afterCondense':function(context){if(typeof $j.collapsibleTabs!='undefined'){$j.collapsibleTabs.handleResize();}}}).siblings('button').css('float','right');});$j(document).ready(function(){if(!wgVectorEnabledModules.footercleanup){return true;}
2525 $j('#editpage-copywarn').add('.editOptions').wrapAll('<div id="editpage-bottom"></div>');$j('#wpSummary').data('hint',$j('#wpSummaryLabel span small').remove().text().replace(/\)|\(/g,'')).change(function(){if($j(this).val().length==0){$j(this).addClass('inline-hint').val($j(this).data('hint'));}else{$j(this).removeClass('inline-hint');}}).focus(function(){if($j(this).val()==$j(this).data('hint')){$j(this).removeClass('inline-hint').val("");}}).blur(function(){$j(this).trigger('change');}).trigger('change');$j('#wpSummary').add('.editCheckboxes').wrapAll('<div id="editpage-summary-fields"></div>');$j('#editpage-specialchars').remove();var transclusionCount=$j('.templatesUsed ul li').size();$j('.templatesUsed ul').wrap('<div id="transclusions-list" class="collapsible-list collapsed"></div>').parent().prepend('<label>This page contains <a href="http://en.wikipedia.org/wiki/transclusion">transclusions</a> of <strong>'
2626 +transclusionCount
2727 +'</strong> other pages.</label>');$j('.mw-templatesUsedExplanation').remove();$j('.collapsible-list label').click(function(){$j(this).parent().toggleClass('expanded').toggleClass('collapsed').find('ul').slideToggle('fast');return false;}).trigger('click');$j('#wpPreview, #wpDiff, .editHelp, #editpage-specialchars').remove();$j('#mw-editform-cancel').remove().appendTo('.editButtons');});if(wgVectorEnabledModules.simplesearch&&skin=='vector'&&typeof os_autoload_inputs!=='undefined'&&os_autoload_forms!=='undefined'){os_autoload_inputs=[];os_autoload_forms=[];}
Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -20,7 +20,7 @@
2121 'raw' => array(
2222 array( 'src' => 'css/suggestions.css', 'version' => 14 ),
2323 array( 'src' => 'css/vector.collapsibleNav.css', 'version' => 11 ),
24 - array( 'src' => 'css/vector.expandableSearch.css', 'version' => 2 ),
 24+ array( 'src' => 'css/vector.expandableSearch.css', 'version' => 3 ),
2525 array( 'src' => 'css/vector.footerCleanup.css', 'version' => 2 ),
2626 array( 'src' => 'css/wikiEditor.css', 'version' => 14 ),
2727 array( 'src' => 'css/wikiEditor.dialogs.css', 'version' => 29 ),
@@ -30,11 +30,11 @@
3131 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3232 ),
3333 'combined' => array(
34 - array( 'src' => 'css/combined.css', 'version' => 99 ),
 34+ array( 'src' => 'css/combined.css', 'version' => 100 ),
3535 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3636 ),
3737 'minified' => array(
38 - array( 'src' => 'css/combined.min.css', 'version' => 99 ),
 38+ array( 'src' => 'css/combined.min.css', 'version' => 100 ),
3939 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
4040 ),
4141 )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67539Expandable Search: Fixing an opera rendering bugadam14:23, 7 June 2010

Comments

#Comment by Catrope (talk | contribs)   16:01, 9 June 2010
+		.css( 'float', 'right' );

What about RTL?

#Comment by Adammiller~mediawikiwiki (talk | contribs)   20:34, 9 June 2010

Fixed in r67757

Status & tagging log