r67496 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67495‎ | r67496 | r67497 >
Date:00:59, 7 June 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Fixed fatal error for QPs caused by bugged refactoring tool
Modified paths:
  • /trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsQP.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersQP.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsQP.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsQP.php
@@ -46,7 +46,7 @@
4747 // TODO: refactor up like done in maps with display point
4848 $markerItems = array();
4949
50 - foreach ( $this->m_locations as $location ) {
 50+ foreach ( $this->mLocations as $location ) {
5151 // Create a string containing the marker JS.
5252 list( $lat, $lon, $title, $label, $icon ) = $location;
5353
@@ -101,4 +101,4 @@
102102 return $params;
103103 }
104104
105 -}
 105+}
\ No newline at end of file
Index: trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersQP.php
@@ -49,7 +49,7 @@
5050 // TODO: refactor up like done in maps with display point
5151 $markerItems = array();
5252
53 - foreach ( $this->m_locations as $location ) {
 53+ foreach ( $this->mLocations as $location ) {
5454 // Create a string containing the marker JS .
5555 list( $lat, $lon, $title, $label, $icon ) = $location;
5656
@@ -100,4 +100,4 @@
101101 return $params;
102102 }
103103
104 -}
 104+}
\ No newline at end of file
Index: trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsQP.php
@@ -66,7 +66,7 @@
6767 // TODO: refactor up like done in maps with display point
6868 $markerItems = array();
6969
70 - foreach ( $this->m_locations as $location ) {
 70+ foreach ( $this->mLocations as $location ) {
7171 list( $lat, $lon, $title, $label, $icon ) = $location;
7272 $markerItems[] = "getGMarkerData($lat, $lon, '$title', '$label', '$icon')";
7373 }
@@ -123,4 +123,4 @@
124124 return $params;
125125 }
126126
127 -}
 127+}
\ No newline at end of file

Status & tagging log