r67491 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67490‎ | r67491 | r67492 >
Date:00:29, 7 June 2010
Author:yaron
Status:deferred
Tags:
Comment:
Mass spelling fix: "spesific" => "specific", "functionallity" => "functionality"
Modified paths:
  • /trunk/extensions/SemanticMaps/Features/FormInputs/SM_FormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Features/QueryPrinters/SM_MapPrinter.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsFunctions.js (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsQP.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersFunctions.js (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersQP.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsFunctions.js (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsQP.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsFunctions.js
@@ -1,5 +1,5 @@
22 /**
3 - * Javascript functions for Yahoo! Maps functionallity in Semantic Maps
 3+ * Javascript functions for Yahoo! Maps functionality in Semantic Maps
44 *
55 * @file SM_YahooMapsFunctions.js
66 * @ingroup SMYahooMaps
@@ -8,7 +8,7 @@
99 */
1010
1111 /**
12 - * This function holds spesific functionallity for the Yahoo! Maps form input of Semantic Maps
 12+ * This function holds specific functionality for the Yahoo! Maps form input of Semantic Maps
1313 * TODO: Refactor as much code as possible to non specific functions
1414 */
1515 function makeFormInputYahooMap(mapName, locationFieldName, lat, lon, zoom, type, types, controls, scrollWheelZoom, marker_lat, marker_lon) {
@@ -36,7 +36,7 @@
3737 }
3838
3939 /**
40 - * This function holds spesific functionallity for the Yahoo! Maps form input of Semantic Maps
 40+ * This function holds specific functionality for the Yahoo! Maps form input of Semantic Maps
4141 * TODO: Refactor as much code as possible to non specific functions
4242 */
4343 function showYAddress(address, mapName, outputElementName, notFoundFormat) {
@@ -51,4 +51,4 @@
5252 document.getElementById(outputElementName).value = convertLatToDMS(resultObj.GeoPoint.Lat) + ', ' + convertLngToDMS(resultObj.GeoPoint.Lon);
5353 }
5454 );
55 -}
\ No newline at end of file
 55+}
Index: trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsQP.php
@@ -86,7 +86,7 @@
8787 }
8888
8989 /**
90 - * Returns type info, descriptions and allowed values for this QP's parameters after adding the spesific ones to the list.
 90+ * Returns type info, descriptions and allowed values for this QP's parameters after adding the specific ones to the list.
9191 */
9292 public function getParameters() {
9393 $params = parent::getParameters();
@@ -101,4 +101,4 @@
102102 return $params;
103103 }
104104
105 -}
\ No newline at end of file
 105+}
Index: trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsFormInput.php
@@ -17,7 +17,7 @@
1818
1919 public $serviceName = MapsYahooMaps::SERVICE_NAME;
2020
21 - protected $spesificParameters = array();
 21+ protected $specificParameters = array();
2222
2323 /**
2424 * @see MapsMapFeature::setMapSettings()
Index: trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersFunctions.js
@@ -1,5 +1,5 @@
22 /**
3 - * Javascript functions for OpenLayers functionallity in Semantic Maps
 3+ * Javascript functions for OpenLayers functionality in Semantic Maps
44 *
55 * @file SM_OpenLayersFunctions.js
66 * @ingroup SMOpenLayers
@@ -8,7 +8,7 @@
99 */
1010
1111 /**
12 - * This function holds spesific functionallity for the Open Layers form input of Semantic Maps
 12+ * This function holds specific functionality for the Open Layers form input of Semantic Maps
1313 */
1414 function makeFormInputOpenLayer(mapName, locationFieldName, lat, lon, zoom, marker_lat, marker_lon, layers, controls, height) {
1515 var markers = Array();
@@ -95,4 +95,4 @@
9696 for (var i = 0; i < markerCollection.length; i++) {
9797 markerLayer.removeMarker(markerCollection[i]);
9898 }
99 -}
\ No newline at end of file
 99+}
Index: trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersQP.php
@@ -89,7 +89,7 @@
9090 }
9191
9292 /**
93 - * Returns type info, descriptions and allowed values for this QP's parameters after adding the spesific ones to the list.
 93+ * Returns type info, descriptions and allowed values for this QP's parameters after adding the specific ones to the list.
9494 */
9595 public function getParameters() {
9696 $params = parent::getParameters();
Index: trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersFormInput.php
@@ -17,7 +17,7 @@
1818
1919 public $serviceName = MapsOpenLayers::SERVICE_NAME;
2020
21 - protected $spesificParameters = array();
 21+ protected $specificParameters = array();
2222
2323 /**
2424 * @see MapsMapFeature::setMapSettings()
Index: trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsFunctions.js
@@ -1,5 +1,5 @@
22 /**
3 - * Javascript functions for Google Maps functionallity in Semantic Maps
 3+ * Javascript functions for Google Maps functionality in Semantic Maps
44 *
55 * @file SM_GoogleMapFunctions.js
66 * @ingroup SMGoogleMaps
@@ -8,7 +8,7 @@
99 */
1010
1111 /**
12 - * This function holds spesific functionallity for the Google Maps form input of Semantic Maps
 12+ * This function holds specific functionality for the Google Maps form input of Semantic Maps
1313 * TODO: Refactor as much code as possible to non specific functions
1414 */
1515 function makeGoogleMapFormInput(mapName, locationFieldName, mapOptions, marker_lat, marker_lon) {
@@ -42,7 +42,7 @@
4343 }
4444
4545 /**
46 - * This function holds spesific functionallity for the Google Maps form input of Semantic Maps
 46+ * This function holds specific functionality for the Google Maps form input of Semantic Maps
4747 */
4848 function showGAddress(address, mapName, outputElementName, notFoundFormat) {
4949 var map = GMaps[mapName];
@@ -62,4 +62,4 @@
6363 }
6464 );
6565
66 -}
\ No newline at end of file
 66+}
Index: trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsQP.php
@@ -18,7 +18,7 @@
1919
2020 public $serviceName = MapsGoogleMaps::SERVICE_NAME;
2121
22 - protected $spesificParameters;
 22+ protected $specificParameters;
2323
2424 /**
2525 * @see SMMapPrinter::setQueryPrinterSettings()
@@ -30,7 +30,7 @@
3131
3232 $this->defaultZoom = $egMapsGoogleMapsZoom;
3333
34 - $this->spesificParameters = array(
 34+ $this->specificParameters = array(
3535 'overlays' => array(
3636 'type' => array( 'string', 'list' ),
3737 'criteria' => array(
@@ -107,7 +107,7 @@
108108 }
109109
110110 /**
111 - * Returns type info, descriptions and allowed values for this QP's parameters after adding the spesific ones to the list.
 111+ * Returns type info, descriptions and allowed values for this QP's parameters after adding the specific ones to the list.
112112 */
113113 public function getParameters() {
114114 $params = parent::getParameters();
@@ -123,4 +123,4 @@
124124 return $params;
125125 }
126126
127 -}
\ No newline at end of file
 127+}
Index: trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsFormInput.php
@@ -19,7 +19,7 @@
2020
2121 public $serviceName = MapsGoogleMaps::SERVICE_NAME;
2222
23 - protected $spesificParameters = array();
 23+ protected $specificParameters = array();
2424
2525 /**
2626 * @see MapsMapFeature::setMapSettings()
Index: trunk/extensions/SemanticMaps/Features/FormInputs/SM_FormInput.php
@@ -1,7 +1,7 @@
22 <?php
33
44 /**
5 - * Abstract class that provides the common functionallity for all map form inputs
 5+ * Abstract class that provides the common functionality for all map form inputs
66 *
77 * @file SM_FormInput.php
88 * @ingroup SemanticMaps
@@ -56,13 +56,13 @@
5757 /*
5858 * Assembliy of the allowed parameters and their information.
5959 * The main parameters (the ones that are shared by everything) are overidden
60 - * by the feature parameters (the ones spesific to a feature). The result is then
61 - * again overidden by the service parameters (the ones spesific to the service),
62 - * and finally by the spesific parameters (the ones spesific to a service-feature combination).
 60+ * by the feature parameters (the ones specific to a feature). The result is then
 61+ * again overidden by the service parameters (the ones specific to the service),
 62+ * and finally by the specific parameters (the ones specific to a service-feature combination).
6363 */
6464 $parameterInfo = array_merge_recursive( MapsMapper::getCommonParameters(), SMFormInputs::$parameters );
6565 $parameterInfo = array_merge_recursive( $parameterInfo, $egMapsServices[$this->serviceName]['parameters'] );
66 - $parameterInfo = array_merge_recursive( $parameterInfo, $this->spesificParameters );
 66+ $parameterInfo = array_merge_recursive( $parameterInfo, $this->specificParameters );
6767
6868 $manager = new ValidatorManager();
6969
@@ -269,4 +269,4 @@
270270 private static function getDynamicInput( $id, $value, $args = '' ) {
271271 return '<input id="' . $id . '" ' . $args . ' value="' . $value . '" onfocus="if (this.value==\'' . $value . '\') {this.value=\'\';}" onblur="if (this.value==\'\') {this.value=\'' . $value . '\';}" />';
272272 }
273 -}
\ No newline at end of file
 273+}
Index: trunk/extensions/SemanticMaps/Features/QueryPrinters/SM_MapPrinter.php
@@ -16,7 +16,7 @@
1717 }
1818
1919 /**
20 - * Abstract class that provides the common functionallity for all map query printers.
 20+ * Abstract class that provides the common functionality for all map query printers.
2121 *
2222 * @ingroup SemanticMaps
2323 *
@@ -34,7 +34,7 @@
3535 protected abstract function setQueryPrinterSettings();
3636
3737 /**
38 - * Map service spesific map count and loading of dependencies
 38+ * Map service specific map count and loading of dependencies
3939 */
4040 protected abstract function doMapServiceLoad();
4141
@@ -58,7 +58,7 @@
5959 protected $mMapFeature;
6060
6161 protected $featureParameters = array();
62 - protected $spesificParameters = array();
 62+ protected $specificParameters = array();
6363
6464 /**
6565 * Builds up and returns the HTML for the map, with the queried coordinate data on it.
@@ -110,13 +110,13 @@
111111 /*
112112 * Assembliy of the allowed parameters and their information.
113113 * The main parameters (the ones that are shared by everything) are overidden
114 - * by the feature parameters (the ones spesific to a feature). The result is then
115 - * again overidden by the service parameters (the ones spesific to the service),
116 - * and finally by the spesific parameters (the ones spesific to a service-feature combination).
 114+ * by the feature parameters (the ones specific to a feature). The result is then
 115+ * again overidden by the service parameters (the ones specific to the service),
 116+ * and finally by the specific parameters (the ones specific to a service-feature combination).
117117 */
118118 $parameterInfo = array_merge_recursive( MapsMapper::getCommonParameters(), $this->featureParameters );
119119 $parameterInfo = array_merge_recursive( $parameterInfo, $egMapsServices[$this->serviceName]['parameters'] );
120 - $parameterInfo = array_merge_recursive( $parameterInfo, $this->spesificParameters );
 120+ $parameterInfo = array_merge_recursive( $parameterInfo, $this->specificParameters );
121121
122122 $manager = new ValidatorManager();
123123
@@ -357,4 +357,4 @@
358358 return $params;
359359 }
360360
361 -}
\ No newline at end of file
 361+}

Status & tagging log