r67461 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67460‎ | r67461 | r67462 >
Date:13:10, 6 June 2010
Author:liangent
Status:deferred
Tags:
Comment:
Cosmetic changes and comments
Modified paths:
  • /trunk/extensions/CategoryMultisort/CategoryMultisort.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CategoryMultisort/CategoryMultisort.hooks.php
@@ -193,10 +193,10 @@
194194 $nt = Title::makeTitleSafe( NS_CATEGORY, $cat );
195195 $wgContLang->findVariantLink( $cat, $nt, true );
196196 $arr[] = array(
197 - 'clms_from' => $linksUpdate->mId,
198 - 'clms_to' => $cat,
 197+ 'clms_from' => $linksUpdate->mId,
 198+ 'clms_to' => $cat,
199199 'clms_sortkey_name' => $skn,
200 - 'clms_sortkey' => $skv,
 200+ 'clms_sortkey' => $skv,
201201 );
202202 }
203203
@@ -229,7 +229,7 @@
230230 }
231231
232232 function parserCategoryLink(
233 - $parser, $holders, $markers, $title, $titleText, &$sortText = null, &$leadingColon = false
 233+ $parser, $holders, $markers, $title, $titleText, &$sortText = null, &$leadingColon = false
234234 ) {
235235 global $wgContLang;
236236
@@ -259,6 +259,7 @@
260260 $sort = null;
261261 }
262262 if ( is_callable( $this->coreCategoryLinkHook ) ) {
 263+ # Will it return any error message?
263264 call_user_func_array( $this->coreCategoryLinkHook, array(
264265 $parser, $holders, $markers, $title, $titleText, &$sort, &$leadingColon
265266 ) );
@@ -313,7 +314,7 @@
314315 $args = func_get_args();
315316 $parser = array_shift( $args );
316317 $categoryDefaultMultisorts = &$parser->getOutput()->mCategoryDefaultMultisorts;
317 -
 318+
318319 foreach ( $this->parseMultisortArgs( $args ) as $skn => $skv ) {
319320 $categoryDefaultMultisorts[$skn] = $skv;
320321 }

Status & tagging log