r67459 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67458‎ | r67459 | r67460 >
Date:13:10, 6 June 2010
Author:liangent
Status:deferred
Tags:
Comment:
Trim both sortkey name and sortkey value
Modified paths:
  • /trunk/extensions/CategoryMultisort/CategoryMultisort.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CategoryMultisort/CategoryMultisort.hooks.php
@@ -403,7 +403,7 @@
404404 continue;
405405 }
406406 list( $skn, $skv ) = $sk;
407 - $skn = $this->cleanSortkey( trim( $skn ) );
 407+ $skn = $this->cleanSortkey( $skn );
408408 $skv = $this->cleanSortkey( $skv );
409409 if ( $skn ) {
410410 $arr[$skn] = $skv;
@@ -416,6 +416,7 @@
417417 function cleanSortkey( $skx ) {
418418 global $wgContLang;
419419
 420+ $skx = trim( $skx );
420421 $skx = Sanitizer::decodeCharReferences( $skx );
421422 $skx = str_replace( "\n", '', $skx );
422423 $skx = $wgContLang->convertCategoryKey( $skx );

Status & tagging log