r67455 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67454‎ | r67455 | r67456 >
Date:11:28, 6 June 2010
Author:catrope
Status:deferred
Tags:
Comment:
UsabilityInitiative: (bug 19334) Textarea jumps when editing articles in IE8. r62191 fixed this, but there was a line in wikiEditor.css overriding a crucial part of that fix.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/combined.min.css (modified) (history)
  • /trunk/extensions/UsabilityInitiative/css/wikiEditor.css (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/css/wikiEditor.css
@@ -13,7 +13,6 @@
1414 .wikiEditor-ui textarea#wpTextbox1 {
1515 border: none;
1616 padding: 0;
17 - width: 100%;
1817 margin: -1px;
1918 line-height: 1.5em;
2019 }
Index: trunk/extensions/UsabilityInitiative/css/combined.css
@@ -152,7 +152,6 @@
153153 .wikiEditor-ui textarea#wpTextbox1 {
154154 border: none;
155155 padding: 0;
156 - width: 100%;
157156 margin: -1px;
158157 line-height: 1.5em;
159158 }
Index: trunk/extensions/UsabilityInitiative/css/combined.min.css
@@ -145,7 +145,6 @@
146146 .wikiEditor-ui textarea#wpTextbox1{
147147 border:none;
148148 padding:0;
149 -width:100%;
150149 margin:-1px;
151150 line-height:1.5em;
152151 }
Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -22,7 +22,7 @@
2323 array( 'src' => 'css/vector.collapsibleNav.css', 'version' => 9 ),
2424 array( 'src' => 'css/vector.expandableSearch.css', 'version' => 1 ),
2525 array( 'src' => 'css/vector.footerCleanup.css', 'version' => 2 ),
26 - array( 'src' => 'css/wikiEditor.css', 'version' => 13 ),
 26+ array( 'src' => 'css/wikiEditor.css', 'version' => 14 ),
2727 array( 'src' => 'css/wikiEditor.dialogs.css', 'version' => 29 ),
2828 array( 'src' => 'css/wikiEditor.preview.css', 'version' => 1 ),
2929 array( 'src' => 'css/wikiEditor.toc.css', 'version' => 31 ),
@@ -30,11 +30,11 @@
3131 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3232 ),
3333 'combined' => array(
34 - array( 'src' => 'css/combined.css', 'version' => 94 ),
 34+ array( 'src' => 'css/combined.css', 'version' => 95 ),
3535 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
3636 ),
3737 'minified' => array(
38 - array( 'src' => 'css/combined.min.css', 'version' => 94 ),
 38+ array( 'src' => 'css/combined.min.css', 'version' => 95 ),
3939 array( 'src' => 'css/vector/jquery-ui-1.7.2.css', 'version' => '1.7.2y' ),
4040 ),
4141 )

Follow-up revisions

RevisionCommit summaryAuthorDate
r674561.16wmf4: MFT r67455catrope11:31, 6 June 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r62191bug #19334: textarea jumps when editing longer articles in IE8ashley19:51, 9 February 2010

Status & tagging log