r67398 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67397‎ | r67398 | r67399 >
Date:11:59, 5 June 2010
Author:churchofemacs
Status:reverted
Tags:
Comment:
follow-up on r67094: fixing presumed cause for php strict standards message and adding to release-notes
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRevisionMove.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRevisionMove.php
@@ -48,12 +48,10 @@
4949
5050 /**
5151 * @param $par subpage part, standard special page parameter, is ignored here
52 - * @param $request optional WebRequest object. If it isn't set, $this->request
53 - * will be set to $wgRequest
5452 *
5553 * Mostly initializes variables and calls either showForm() or submit()
5654 */
57 - public function execute( $par = '', $request = null ) {
 55+ public function execute( $par = '' ) {
5856 global $wgUser, $wgOut, $wgSkin;
5957
6058 $this->setHeaders();
@@ -62,10 +60,8 @@
6361 $this->mIsAllowedRevisionMove = $wgUser->isAllowed( 'revisionmove' );
6462 $this->user = $wgUser;
6563 $this->skin = $wgUser->getSkin();
66 - if ( !$request instanceof WebRequest ) {
 64+ if ( !$this->request instanceof WebRequest ) {
6765 $this->request = $GLOBALS['wgRequest'];
68 - } else {
69 - $this->request = $request;
7066 }
7167
7268 # Get correct title
Index: trunk/phase3/RELEASE-NOTES
@@ -77,6 +77,9 @@
7878 notified about the beginning and finishing of LivePreview actions.
7979 * (bug 21278) Now the sidebar allows inclusion of wiki markup.
8080 * (bug 23733) Add IDs to messages used on CSS/JS pages
 81+* (bug 21312) RevisionMove allows moving individual revisions of a page to
 82+ another page. Introducing 'revisionmove' user right; disabled by default;
 83+ experimental feature.
8184
8285 === Bug fixes in 1.17 ===
8386 * (bug 17560) Half-broken deletion moved image files to deletion archive

Follow-up revisions

RevisionCommit summaryAuthorDate
r814481.17: Revert r67094 (RevisionMove) and followups including r67099, r67111, r6...catrope13:22, 3 February 2011
r86155Merge r81448 from REL1_17: reverting RevisionMove feature back out until some...demon23:28, 15 April 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67094New feature RevisionMove (bug 21312). Introducing SpecialRevisionMove.php and...churchofemacs18:00, 30 May 2010

Status & tagging log