r67394 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67393‎ | r67394 | r67395 >
Date:09:40, 5 June 2010
Author:daniel
Status:deferred
Tags:
Comment:
fixed hard-coded table names
Modified paths:
  • /trunk/WikiWord/WikiWordBuilder/src/main/java/de/brightbyte/wikiword/store/builder/DatabasePropertyStoreBuilder.java (modified) (history)

Diff [purge]

Index: trunk/WikiWord/WikiWordBuilder/src/main/java/de/brightbyte/wikiword/store/builder/DatabasePropertyStoreBuilder.java
@@ -112,7 +112,7 @@
113113
114114 protected boolean hasUnresolvedConceptReferences() throws PersistenceException{
115115 try {
116 - Number c = (Number)database.executeSingleValueQuery("DatabasePropertyStoreBuilder.finishAliases#hasNull?", "select exists(select * from wmde10apr_en_property where concept is null)");
 116+ Number c = (Number)database.executeSingleValueQuery("DatabasePropertyStoreBuilder.finishAliases#hasNull?", "select exists(select * from "+propertyTable.getSQLName()+" where concept is null)");
117117 return c.intValue() > 0;
118118 } catch (SQLException e) {
119119 throw new PersistenceException(e);
@@ -121,7 +121,7 @@
122122
123123 protected boolean hasResolvedConceptReferences() throws PersistenceException {
124124 try {
125 - Number c = (Number)database.executeSingleValueQuery("DatabasePropertyStoreBuilder.finishAliases#hasNull?", "select exists(select * from wmde10apr_en_property where concept is not null)");
 125+ Number c = (Number)database.executeSingleValueQuery("DatabasePropertyStoreBuilder.finishAliases#hasNull?", "select exists(select * from "+propertyTable.getSQLName()+" where concept is not null)");
126126 return c.intValue() > 0;
127127 } catch (SQLException e) {
128128 throw new PersistenceException(e);

Status & tagging log