r67333 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67332‎ | r67333 | r67334 >
Date:09:54, 4 June 2010
Author:catrope
Status:deferred
Tags:
Comment:
1.16wmf4: MFT r67332
Modified paths:
  • /branches/wmf/1.16wmf4/extensions/ContactPage (modified) (history)
  • /branches/wmf/1.16wmf4/extensions/ContactPage/SpecialContact.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/extensions/ContactPage/SpecialContact.php
@@ -230,11 +230,11 @@
231231 Xml::textarea( 'wpText', $this->text, 80, 20, array( 'id' => 'wpText' ) ) .
232232 '</td>
233233 </tr>';
234 - if ( $wgContactIncludeIP ) {
 234+ if ( $wgContactIncludeIP && $wgUser->isLoggedIn() ) {
235235 $form .= '<tr>
236236 <td></td>
237237 <td class="mw-input">' .
238 - Xml::checkLabel( wfMsg( 'contactpage-includeip' ), 'wpIncludeIP', 'wpIncludeIP', $wgUser->isAnon() ) .
 238+ Xml::checkLabel( wfMsg( 'contactpage-includeip' ), 'wpIncludeIP', 'wpIncludeIP', false ) .
239239 '</td>
240240 </tr>';
241241 }
@@ -300,7 +300,7 @@
301301 }
302302
303303 function doSubmit() {
304 - global $wgOut;
 304+ global $wgOut, $wgUser;
305305 global $wgEnableEmail, $wgUserEmailUseReplyTo, $wgEmergencyContact;
306306 global $wgContactUser, $wgContactSender, $wgContactSenderName, $wgContactIncludeIP;
307307
@@ -329,7 +329,7 @@
330330 $subject = wfMsgForContent( 'contactpage-defsubject' );
331331 }
332332
333 - $includeIP = $wgContactIncludeIP && $this->includeIP;
 333+ $includeIP = $wgContactIncludeIP && ( $this->includeIP || $wgUser->isAnon() );
334334 if ( $this->fromname !== '' ) {
335335 if ( $includeIP ) {
336336 $subject = wfMsgForContent( 'contactpage-subject-and-sender-withip', $subject, $this->fromname, $senderIP );
Property changes on: branches/wmf/1.16wmf4/extensions/ContactPage
___________________________________________________________________
Name: svn:mergeinfo
337337 - /branches/wmf-deployment/extensions/ContactPage:60970
/trunk/extensions/ContactPage:62820-67074
/trunk/phase3/extensions/ContactPage:63545-63546,63549,63643,63764,63897-63901,64113,64509,65387,65391,65555,65590,65650,65816
338338 + /branches/wmf-deployment/extensions/ContactPage:60970
/trunk/extensions/ContactPage:62820-67074,67332
/trunk/phase3/extensions/ContactPage:63545-63546,63549,63643,63764,63897-63901,64113,64509,65387,65391,65555,65590,65650,65816

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67332ContactPage: Tweak $wgContactIncludeIP behavior per bug 22741 comment #11: ch...catrope09:52, 4 June 2010

Status & tagging log