r67300 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r67299‎ | r67300 | r67301 >
Date:21:42, 3 June 2010
Author:tparscal
Status:resolved (Comments)
Tags:
Comment:
Revert r66608: This goes against an intentional design decision. To discuss that decision further and submit proposals to change this design please contact Howie Fung <hfung@wikimedia.org> or visit http://usability.wikimedia.org
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/skins/chick/main.css (modified) (history)
  • /trunk/phase3/skins/common/commonPrint.css (modified) (history)
  • /trunk/phase3/skins/modern/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/vector/main-ltr.css (modified) (history)
  • /trunk/phase3/skins/vector/main-rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/chick/main.css
——@@ -19,7 +19,7 @@
2020 a:active { color: #ffa500; }
2121 a.stub { color: #772233; }
2222 a.new,
23 -#p-personal a.new { color:#CC2200; }
 23+#p-personal a.new { color:#ba0000; }
2424 a.new:visited,
2525 #p-personal a.new:visited { color:#a55858; }
2626
Index: trunk/phase3/skins/monobook/main.css
——@@ -829,7 +829,7 @@
830830 background-color: white;
831831 }
832832 #p-cactions .new a {
833 - color: #CC2200;
 833+ color: #ba0000;
834834 }
835835 #p-cactions li a:hover {
836836 z-index: 3;
Index: trunk/phase3/skins/modern/main.css
——@@ -318,7 +318,7 @@
319319 color: #772233;
320320 }
321321 a.new {
322 - color: #CC2200;
 322+ color: #ba0000;
323323 }
324324 a.new:visited {
325325 color: #a55858;
Index: trunk/phase3/skins/common/commonPrint.css
——@@ -9,7 +9,7 @@
1010 /* Thanks to A List Apart (http://alistapart.com/) for useful extras */
1111 a.stub,
1212 a.new {
13 - color: #CC2200;
 13+ color: #ba0000;
1414 text-decoration: none;
1515 }
1616
Index: trunk/phase3/skins/vector/main-ltr.css
——@@ -639,7 +639,7 @@
640640 color: #772233;
641641 }
642642 a.new, #p-personal a.new {
643 - color: #CC2200;
 643+ color: #ba0000;
644644 }
645645 a.new:visited, #p-personal a.new:visited {
646646 color: #a55858;
Index: trunk/phase3/skins/vector/main-rtl.css
——@@ -639,7 +639,7 @@
640640 color: #772233;
641641 }
642642 a.new, #p-personal a.new {
643 - color: #CC2200;
 643+ color: #ba0000;
644644 }
645645 a.new:visited, #p-personal a.new:visited {
646646 color: #a55858;
Index: trunk/phase3/includes/Skin.php
——@@ -557,7 +557,9 @@
558558 $underline = $undopt ? 'underline' : 'none';
559559 $s .= "a { text-decoration: $underline; }\n";
560560 }
561 - if( !$wgUser->getOption( 'highlightbroken' ) ) {
 561+ if( $wgUser->getOption( 'highlightbroken' ) ) {
 562+ $s .= "a.new, #quickbar a.new { color: #CC2200; }\n";
 563+ } else {
562564 $s .= <<<CSS
563565 a.new, #quickbar a.new,
564566 a.stub, #quickbar a.stub {

Follow-up revisions

RevisionCommit summaryAuthorDate
r74692Finished what r67300 started, by using #ba0000 as the broken "red" link color.tparscal21:28, 12 October 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66608Follow up r63707: update the default link colour in all skins to match what's...happy-melon13:01, 18 May 2010

Comments

#Comment by Happy-melon (talk | contribs)   23:13, 3 June 2010

Is it so hard to say what that design decision is, rather than ask people to either start a private conversation, or search an entire wiki? Whatever the decision is, it seems to be many years old...

#Comment by Skizzerz (talk | contribs)   01:17, 7 June 2010

this revert has no effect due to the revert of /includes/Skin.php -- reverting this revision's change will allow css changes to the a.new color to actually take effect instead of being silently replaced by #CC2200

marked as fixme until this is changed so that your "intentional design decisions" will actually work as you designed them.

#Comment by Trevor Parscal (WMF) (talk | contribs)   21:29, 12 October 2010

ResourceLoaderUserOptionsModule has been updated to make #ba0000 not get overrident with #CC2200.

Status & tagging log