r67297 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67296‎ | r67297 | r67298 >
Date:21:00, 3 June 2010
Author:ialex
Status:ok
Tags:
Comment:
Fixed some doxygen warnings
Modified paths:
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -65,6 +65,7 @@
6666
6767 /**
6868 * Show options for the log list
 69+ *
6970 * @param $types string or Array
7071 * @param $user String
7172 * @param $page String
@@ -536,7 +537,7 @@
537538 * @param $type Mixed: string/array
538539 * @param $action Mixed: string/array
539540 * @param $right string
540 - * @return bool
 541+ * @return Boolean
541542 */
542543 public static function typeAction( $row, $type, $action, $right='' ) {
543544 $match = is_array($type) ?
@@ -555,6 +556,7 @@
556557 /**
557558 * Determine if the current user is allowed to view a particular
558559 * field of this log row, if it's marked as deleted.
 560+ *
559561 * @param $row Row
560562 * @param $field Integer
561563 * @return Boolean
@@ -562,10 +564,11 @@
563565 public static function userCan( $row, $field ) {
564566 return self::userCanBitfield( $row->log_deleted, $field );
565567 }
566 -
 568+
567569 /**
568570 * Determine if the current user is allowed to view a particular
569571 * field of this log row, if it's marked as deleted.
 572+ *
570573 * @param $bitfield Integer (current field)
571574 * @param $field Integer
572575 * @return Boolean
@@ -597,6 +600,7 @@
598601
599602 /**
600603 * Show log extract. Either with text and a box (set $msgKey) or without (don't set $msgKey)
 604+ *
601605 * @param $out OutputPage or String-by-reference
602606 * @param $types String or Array
603607 * @param $page String The page title to show log entries for
@@ -706,9 +710,10 @@
707711
708712 /**
709713 * SQL clause to skip forbidden log types for this user
 714+ *
710715 * @param $db Database
711716 * @param $audience string, public/user
712 - * @return mixed (string or false)
 717+ * @return Mixed: string or false
713718 */
714719 public static function getExcludeClause( $db, $audience = 'public' ) {
715720 global $wgLogRestrictions, $wgUser;
@@ -739,15 +744,17 @@
740745 public $mLogEventsList;
741746
742747 /**
743 - * constructor
 748+ * Constructor
 749+ *
744750 * @param $list LogEventsList
745 - * @param $types String or Array log types to show
746 - * @param $user String The user who made the log entries
747 - * @param $title String The page title the log entries are for
748 - * @param $pattern String Do a prefix search rather than an exact title match
749 - * @param $conds Array Extra conditions for the query
750 - * @param $year Integer The year to start from
751 - * @param $month Integer The month to start from
 751+ * @param $types String or Array: log types to show
 752+ * @param $user String: the user who made the log entries
 753+ * @param $title String: the page title the log entries are for
 754+ * @param $pattern String: do a prefix search rather than an exact title match
 755+ * @param $conds Array: extra conditions for the query
 756+ * @param $year Integer: the year to start from
 757+ * @param $month Integer: the month to start from
 758+ * @param $tagFilter String: tag
752759 */
753760 public function __construct( $list, $types = array(), $user = '', $title = '', $pattern = '',
754761 $conds = array(), $year = false, $month = false, $tagFilter = '' )
@@ -795,6 +802,7 @@
796803 /**
797804 * Set the log reader to return only entries of the given type.
798805 * Type restrictions enforced here
 806+ *
799807 * @param $types String or array: Log types ('upload', 'delete', etc);
800808 * empty string means no restriction
801809 */
@@ -827,6 +835,7 @@
828836
829837 /**
830838 * Set the log reader to return only entries by the given user.
 839+ *
831840 * @param $name String: (In)valid user name
832841 */
833842 private function limitUser( $name ) {
@@ -860,6 +869,7 @@
861870 /**
862871 * Set the log reader to return only entries affecting the given page.
863872 * (For the block and rights logs, this is a user page.)
 873+ *
864874 * @param $page String: Title name as text
865875 * @param $pattern String
866876 */
@@ -1014,6 +1024,7 @@
10151025 */
10161026 class LogReader {
10171027 var $pager;
 1028+
10181029 /**
10191030 * @param $request WebRequest: for internal use use a FauxRequest object to pass arbitrary parameters.
10201031 */
@@ -1102,6 +1113,7 @@
11031114 * Output just the list of entries given by the linked LogReader,
11041115 * with extraneous UI elements. Use for displaying log fragments in
11051116 * another page (eg at Special:Undelete)
 1117+ *
11061118 * @param $out OutputPage: where to send output
11071119 */
11081120 public function showList( &$out ) {

Status & tagging log