r67294 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67293‎ | r67294 | r67295 >
Date:19:12, 3 June 2010
Author:aaron
Status:ok
Tags:
Comment:
Sanity check $wgFlaggedRevsNamespaces
Modified paths:
  • /trunk/extensions/FlaggedRevs/maintenance/purgeReviewablePages.inc (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/maintenance/purgeReviewablePages.inc
@@ -5,11 +5,13 @@
66 echo "Purging squid cache for all reviewable pages...\n";
77 if ( !$wgUseSquid || !$wgUseFileCache ) {
88 echo "Squid/file cache not enabled...nothing to purge.\n";
 9+ } elseif ( empty( $wgFlaggedRevsNamespaces ) ) {
 10+ echo "There are no reviewable namespaces...nothing to purge.\n";
911 }
1012 $BATCH_SIZE = 500;
1113 $start = $db->selectField( 'page', 'MIN(page_id)', false, __FUNCTION__ );
1214 $end = $db->selectField( 'page', 'MAX(page_id)', false, __FUNCTION__ );
13 - if ( is_null( $start ) || is_null( $end ) ){
 15+ if ( is_null( $start ) || is_null( $end ) ) {
1416 echo "...page table seems to be empty.\n";
1517 return;
1618 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r67301* Split purgeReviewablePages.php into two phases. Nice for uninstallation and...aaron22:08, 3 June 2010

Status & tagging log