r67289 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r67288‎ | r67289 | r67290 >
Date:18:07, 3 June 2010
Author:bawolff
Status:ok
Tags:
Comment:
Follow up to 66670 which in turn is a follow up to r66646. prefix the remaining id selectors with div

Doing just some of them caused breakage on IE6, as the selectors in main had
higher speciftivity then those in IE60Fixes. So add div to all of them.
Modified paths:
  • /trunk/phase3/skins/monobook/IE50Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/IE55Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/IE60Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/IE70Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/Opera6Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/Opera6Fixes.css
——@@ -1,5 +1,5 @@
22 /* opera 6 fixes */
3 -#column-one {
 3+div#column-one {
44 position: relative;
55 max-width: 11.7em;
66 }
Index: trunk/phase3/skins/monobook/rtl.css
——@@ -26,11 +26,11 @@
2727 direction: rtl;
2828 unicode-bidi: embed;
2929 }
30 -#column-content {
 30+div#column-content {
3131 margin: 0 -12.2em 0 0;
3232 float: left;
3333 }
34 -#column-content #content{
 34+div#column-content div#content{
3535 margin-left: 0;
3636 margin-right: 12.2em;
3737 border-right: 1px solid #aaaaaa;
——@@ -153,7 +153,7 @@
154154 background: none !important;
155155 }
156156 */
157 -#footer {
 157+div#footer {
158158 clear: both;
159159 }
160160 #f-poweredbyico {
——@@ -164,22 +164,22 @@
165165 float: right;
166166 height: 1%;
167167 }
168 -* html #footer {
 168+* html div#footer {
169169 margin-left: 0;
170170 margin-right: 13.6em;
171171 border-left: 0;
172172 border-right: 1px solid #fabd23;
173173 }
174 -* html #column-content {
 174+* html div#column-content {
175175 float: none;
176176 margin-left: 0;
177177 margin-right: 0;
178178 }
179 -* html #column-content #content {
 179+* html div#column-content div#content {
180180 margin-left: 0;
181181 margin-top: 3em;
182182 }
183 -* html #column-one { right: 0; }
 183+* html div#column-one { right: 0; }
184184
185185 /* js pref toc */
186186
Index: trunk/phase3/skins/monobook/IE50Fixes.css
——@@ -2,22 +2,22 @@
33 ** IE5.0 Fix Stylesheet
44 */
55
6 -#column-content {
 6+div#column-content {
77 margin: 0 !important;
88 float: none;
99 }
10 -#column-content #content {
 10+div#column-content #content {
1111 margin-top: 3em;
1212 height: 1%;
1313 }
14 -#column-one {
 14+div#column-one {
1515 position: absolute;
1616 overflow: visible;
1717 top: 0;
1818 left: 0;
1919 z-index: 3;
2020 }
21 -#footer {
 21+div#footer {
2222 margin: 0 0 0 13.6em;
2323 }
2424
Index: trunk/phase3/skins/monobook/IE60Fixes.css
——@@ -1,23 +1,23 @@
22 /* 6.0 - only fixes */
33 /* content area */
44 /* workaround for various ie float bugs */
5 -#column-content {
 5+div#column-content {
66 float: none;
77 margin-left: 0;
88 height: 1%;
99 }
10 -#column-content #content {
 10+div#column-content div#content {
1111 margin-left: 12.2em;
1212 margin-top: 3em;
1313 height: 1%;
1414 }
15 -#column-one {
 15+div#column-one {
1616 position: absolute;
1717 top: 0;
1818 left: 0;
1919 z-index: 4;
2020 }
21 -#footer {
 21+div#footer {
2222 margin-left: 13.6em;
2323 border-left: 1px solid #fabd23;
2424 }
Index: trunk/phase3/skins/monobook/IE70Fixes.css
——@@ -3,13 +3,13 @@
44 /* workaround for various ie float bugs */
55
66 /* This bit is needed to make links clickable... WTF */
7 -#column-content #content {
 7+div#column-content div#content {
88 margin-left: 12.2em;
99 margin-top: 3em;
1010 height: 1%;
1111 }
1212
13 -.rtl #column-one {
 13+.rtl div#column-one {
1414 /* For some reason it tries to inherit the padding-top into every div,
1515 * and I can't figure out how to get it back off.
1616 * Margin works correctly for this use, though.
——@@ -78,7 +78,7 @@
7979 */
8080
8181
82 -#footer li {
 82+div#footer li {
8383 /* Work around bug with inline <li> tags with right margins and nowrap */
8484 margin-right: 0;
8585 }
Index: trunk/phase3/skins/monobook/IE55Fixes.css
——@@ -1,25 +1,25 @@
22 /* IE5.5/win- only fixes */
33
4 -#column-content {
 4+div#column-content {
55 float: none;
66 margin-left: 0;
77 height: 1%;
88 }
9 -#column-content #content {
 9+div#column-content #content {
1010 position: relative;
1111 z-index: 5;
1212 margin-left: 12.2em;
1313 margin-top: 3em;
1414 height: 1%;
1515 }
16 -#column-one {
 16+div#column-one {
1717 position: absolute;
1818 top: 0;
1919 left: 0;
2020 z-index: 4;
2121 width: 100%;
2222 }
23 -#footer {
 23+div#footer {
2424 margin-left: 13.6em;
2525 border-left: 1px solid #fabd23;
2626 }
Index: trunk/phase3/skins/monobook/main.css
——@@ -1091,8 +1091,8 @@
10921092
10931093 /* more IE fixes */
10941094 /* float/negative margin brokenness */
1095 -* html #footer {margin-top: 0;}
1096 -* html #column-content {
 1095+* html div#footer {margin-top: 0;}
 1096+* html div#column-content {
10971097 display: inline;
10981098 margin-bottom: 0;
10991099 }
——@@ -1100,15 +1100,15 @@
11011101 #pagehistory li.selected { position: relative; }
11021102
11031103 /* Mac IE 5.0 fix; floated content turns invisible */
1104 -* > html #column-content {
 1104+* > html div#column-content {
11051105 float: none;
11061106 }
1107 -* > html #column-one {
 1107+* > html div#column-one {
11081108 position: absolute;
11091109 left: 0;
11101110 top: 0;
11111111 }
1112 -* > html #footer {
 1112+* > html div#footer {
11131113 margin-left: 13.2em;
11141114 }
11151115 .redirectText {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66646(bug 23597) Make a number of ID selectors more specific (basically #foo -> di...catrope19:01, 19 May 2010

Status & tagging log