| Index: trunk/phase3/includes/User.php |
| — | — | @@ -3714,6 +3714,10 @@ |
| 3715 | 3715 | * |
| 3716 | 3716 | * Obviously, you still need to do server-side checking. |
| 3717 | 3717 | * |
| | 3718 | + * NOTE: A combination of bugs in various browsers means that this function |
| | 3719 | + * actually just returns array() unconditionally at the moment. May as |
| | 3720 | + * well keep it around for when the browser bugs get fixed, though. |
| | 3721 | + * |
| 3718 | 3722 | * @return array Array of HTML attributes suitable for feeding to |
| 3719 | 3723 | * Html::element(), directly or indirectly. (Don't feed to Xml::*()! |
| 3720 | 3724 | * That will potentially output invalid XHTML 1.0 Transitional, and will |
| — | — | @@ -3728,7 +3732,14 @@ |
| 3729 | 3733 | |
| 3730 | 3734 | # Note that the pattern requirement will always be satisfied if the |
| 3731 | 3735 | # input is empty, so we need required in all cases. |
| 3732 | | - $ret = array( 'required' ); |
| | 3736 | + # |
| | 3737 | + # FIXME (bug 23769): This needs to not claim the password is required |
| | 3738 | + # if e-mail confirmation is being used. Since HTML5 input validation |
| | 3739 | + # is b0rked anyway in some browsers, just return nothing. When it's |
| | 3740 | + # re-enabled, fix this code to not output required for e-mail |
| | 3741 | + # registration. |
| | 3742 | + #$ret = array( 'required' ); |
| | 3743 | + $ret = array(); |
| 3733 | 3744 | |
| 3734 | 3745 | # We can't actually do this right now, because Opera 9.6 will print out |
| 3735 | 3746 | # the entered password visibly in its error message! When other |