r67221 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67220‎ | r67221 | r67222 >
Date:15:51, 2 June 2010
Author:daniel
Status:deferred
Tags:
Comment:
fiddle with re-substitution problem. no solution yet, added a comment as a reminder
Modified paths:
  • /trunk/extensions/DataTransclusion/DataTransclusionHandler.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DataTransclusion/DataTransclusionHandler.php
@@ -52,7 +52,7 @@
5353 // build associative arguments from flat parameter list
5454 $argv = DataTransclusionHandler::buildAssociativeArguments( $params );
5555
56 - // now handle just like a <record> tag
 56+ //FIXME: error messages contining special blocks like <nowiki> don't get re-substitutet correctly.
5757 $text = DataTransclusionHandler::handleRecordTag( null, $argv, $parser, false );
5858 return array( $text, 'noparse' => false, 'isHTML' => false );
5959 }
@@ -162,7 +162,7 @@
163163 if ( !$p->exists() ) return false;
164164
165165 $text = $p->getContent();
166 - $text = $parser->replaceVariables( $text, $record );
 166+ $text = $parser->replaceVariables( $text, $record, true );
167167
168168 return $text;
169169 }

Status & tagging log