r67192 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67191‎ | r67192 | r67193 >
Date:18:21, 1 June 2010
Author:yaron
Status:deferred
Tags:
Comment:
Added explicit "static" declaration to some static functions
Modified paths:
  • /trunk/extensions/SemanticDrilldown/includes/SD_AppliedFilter.php (modified) (history)
  • /trunk/extensions/SemanticDrilldown/includes/SD_Filter.php (modified) (history)
  • /trunk/extensions/SemanticDrilldown/includes/SD_FilterValue.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticDrilldown/includes/SD_AppliedFilter.php
@@ -15,7 +15,7 @@
1616 var $lower_date_string;
1717 var $upper_date_string;
1818
19 - function create( $filter, $values, $search_term = null, $lower_date = null, $upper_date = null ) {
 19+ static function create( $filter, $values, $search_term = null, $lower_date = null, $upper_date = null ) {
2020 $af = new SDAppliedFilter();
2121 $af->filter = $filter;
2222 $af->search_term = htmlspecialchars( str_replace( '_', ' ', $search_term ) );
Index: trunk/extensions/SemanticDrilldown/includes/SD_Filter.php
@@ -18,7 +18,7 @@
1919 var $allowed_values;
2020 var $possible_applied_filters = array();
2121
22 - function load( $filter_name ) {
 22+ static function load( $filter_name ) {
2323 $f = new SDFilter();
2424 $f->name = $filter_name;
2525 $properties_used = SDUtils::getValuesForProperty( $filter_name, SD_NS_FILTER, '_SD_CP', SD_SP_COVERS_PROPERTY, SMW_NS_PROPERTY );
Index: trunk/extensions/SemanticDrilldown/includes/SD_FilterValue.php
@@ -16,7 +16,7 @@
1717 var $year = null;
1818 var $month = null;
1919
20 - function create( $actual_val, $filter_time_period = null ) {
 20+ static function create( $actual_val, $filter_time_period = null ) {
2121 $fv = new SDFilterValue();
2222 $fv->text = htmlspecialchars( $actual_val );
2323

Status & tagging log