r67190 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67189‎ | r67190 | r67191 >
Date:16:31, 1 June 2010
Author:ialex
Status:ok
Tags:
Comment:
svn:eol-style native
Modified paths:
  • /trunk/extensions/DataTransclusion/DBDataTransclusionSource.php (modified) (history)
  • /trunk/extensions/DataTransclusion/DataTransclusion.i18n.php (modified) (history)
  • /trunk/extensions/DataTransclusion/DataTransclusion.php (modified) (history)
  • /trunk/extensions/DataTransclusion/DataTransclusionHandler.php (modified) (history)
  • /trunk/extensions/DataTransclusion/DataTransclusionSource.php (modified) (history)
  • /trunk/extensions/FBConnect/FBConnect.alias.php (modified) (history)
  • /trunk/extensions/FBConnect/FBConnect.i18n.php (modified) (history)
  • /trunk/extensions/FBConnect/FBConnect.php (modified) (history)
  • /trunk/extensions/FBConnect/FBConnectAPI.php (modified) (history)
  • /trunk/extensions/FBConnect/FBConnectDB.php (modified) (history)
  • /trunk/extensions/FBConnect/FBConnectHooks.php (modified) (history)
  • /trunk/extensions/FBConnect/FBConnectPushEvent.php (modified) (history)
  • /trunk/extensions/FBConnect/FBConnectUser.php (modified) (history)
  • /trunk/extensions/FBConnect/FBConnectXFBML.php (modified) (history)
  • /trunk/extensions/FBConnect/PreferencesExtension.php (modified) (history)
  • /trunk/extensions/FBConnect/SpecialConnect.php (modified) (history)
  • /trunk/extensions/FBConnect/config.default.php (modified) (history)
  • /trunk/extensions/FBConnect/fbconnect.css (modified) (history)
  • /trunk/extensions/FBConnect/fbconnect.js (modified) (history)
  • /trunk/extensions/FBConnect/fbconnect.min.js (modified) (history)
  • /trunk/extensions/FBConnect/fbconnect_table.pg.sql (modified) (history)
  • /trunk/extensions/FBConnect/fbconnect_table.sql (modified) (history)
  • /trunk/extensions/FBConnect/php-sdk/facebook.php (modified) (history)
  • /trunk/extensions/FBConnect/pushEvents/FBPush_OnAddImage.i18n.php (modified) (history)
  • /trunk/extensions/FBConnect/pushEvents/FBPush_OnAddImage.php (modified) (history)
  • /trunk/extensions/FBConnect/pushEvents/FBPush_OnLargeEdit.i18n.php (modified) (history)
  • /trunk/extensions/FBConnect/pushEvents/FBPush_OnLargeEdit.php (modified) (history)
  • /trunk/extensions/FBConnect/pushEvents/FBPush_OnWatchArticle.i18n.php (modified) (history)
  • /trunk/extensions/FBConnect/pushEvents/FBPush_OnWatchArticle.php (modified) (history)
  • /trunk/extensions/JS2Support/mwEmbed/tests/selenium_tests/amw-all-providers.php (modified) (history)
  • /trunk/extensions/JS2Support/mwEmbed/tests/selenium_tests/api-proxy.php (modified) (history)
  • /trunk/extensions/JS2Support/mwEmbed/tests/selenium_tests/audio-player-menu.php (modified) (history)
  • /trunk/extensions/JS2Support/mwEmbed/tests/selenium_tests/audio-player-playback-progress.php (modified) (history)
  • /trunk/extensions/JS2Support/mwEmbed/tests/selenium_tests/player-themable-display.php (modified) (history)
  • /trunk/extensions/JS2Support/mwEmbed/tests/selenium_tests/player-timed-text.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/libs/jquery-1.4.2.min.js (modified) (history)
  • /trunk/extensions/StrategyWiki/ActiveStrategy/ParserFunctions.php (modified) (history)
  • /trunk/phase3/maintenance/tests/selenium/LocalSeleniumSettings.php.sample (modified) (history)
  • /trunk/phase3/maintenance/tests/selenium/SimpleSeleniumTest.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/selenium/SimpleSeleniumTest.php
@@ -1,31 +1,31 @@
2 -<?php
3 -
4 -if (!defined('MEDIAWIKI') || !defined('SELENIUMTEST')) {
5 - echo "This script cannot be run standalone";
6 - exit(1);
7 -}
8 -
9 -// create test suite
10 -$wgSeleniumTestSuites['SimpleSeleniumTest'] = new SeleniumTestSuite('Simple Selenium Test');
11 -$wgSeleniumTestSuites['SimpleSeleniumTest']->addTest(new SimpleSeleniumTest());
12 -
13 -class SimpleSeleniumTest extends SeleniumTestCase
14 -{
15 - public $name = "Basic selenium test";
16 -
17 - public function runTest()
18 - {
19 - global $wgSeleniumTestsWikiUrl;
20 - $this->open($wgSeleniumTestsWikiUrl.'/index.php?title=Selenium&action=edit');
21 - $this->type("wpTextbox1", "This is a basic test");
22 - $this->click("wpPreview");
23 - $this->waitForPageToLoad(10000);
24 -
25 - // check result
26 - $source = $this->getText("//div[@id='wikiPreview']/p");
27 - $correct = strstr($source, "This is a basic test");
28 - $this->assertEquals($correct, true);
29 -
30 - }
31 -
 2+<?php
 3+
 4+if (!defined('MEDIAWIKI') || !defined('SELENIUMTEST')) {
 5+ echo "This script cannot be run standalone";
 6+ exit(1);
 7+}
 8+
 9+// create test suite
 10+$wgSeleniumTestSuites['SimpleSeleniumTest'] = new SeleniumTestSuite('Simple Selenium Test');
 11+$wgSeleniumTestSuites['SimpleSeleniumTest']->addTest(new SimpleSeleniumTest());
 12+
 13+class SimpleSeleniumTest extends SeleniumTestCase
 14+{
 15+ public $name = "Basic selenium test";
 16+
 17+ public function runTest()
 18+ {
 19+ global $wgSeleniumTestsWikiUrl;
 20+ $this->open($wgSeleniumTestsWikiUrl.'/index.php?title=Selenium&action=edit');
 21+ $this->type("wpTextbox1", "This is a basic test");
 22+ $this->click("wpPreview");
 23+ $this->waitForPageToLoad(10000);
 24+
 25+ // check result
 26+ $source = $this->getText("//div[@id='wikiPreview']/p");
 27+ $correct = strstr($source, "This is a basic test");
 28+ $this->assertEquals($correct, true);
 29+
 30+ }
 31+
3232 }
\ No newline at end of file
Property changes on: trunk/phase3/maintenance/tests/selenium/SimpleSeleniumTest.php
___________________________________________________________________
Added: svn:eol-style
3333 + native
Index: trunk/phase3/maintenance/tests/selenium/LocalSeleniumSettings.php.sample
@@ -1,51 +1,51 @@
2 -<?php
3 -// This template file contains variables that should be localized.
4 -// The line (specifying the location of the PHP/PEAR libraries) must be
5 -// first. Moving it to a position later in the file will almost certainly
6 -// cause an error.
7 -
8 -// In order to use this file, first copy it to LocalSeleniumSettings.php.
9 -// Then edit the information to conform to the local environment. You
10 -// will almost certainly have to uncomment the line set_include_path ... and
11 -// change the string 'PEAR' to the path to your PEAR library, e.g.,
12 -// '/usr/share/php/PEAR' for a Debian based Linux system.
13 -// The edited file must appear in the same directory as does RunSeleniumTests.php.
14 -
15 -// include path. Set 'PEAR" to '/path/to/PEAR/library'
16 -
17 -// URL: http://localhost/tests/RunSeleniumTests.php
18 -#set_include_path( get_include_path() . PATH_SEPARATOR . 'PEAR' );
19 -
20 -// Hostname of selenium server
21 -$wgSeleniumTestsSeleniumHost = 'localhost';
22 -
23 -// URL of the wiki to be tested. Consult web server configuration.
24 -$wgSeleniumTestsWikiUrl = 'http://localhost';
25 -
26 -// Port used by selenium server (optional - default is 4444)
27 -$wgSeleniumServerPort = 4444;
28 -
29 -// Wiki login. Used by Selenium to log onto the wiki
30 -$wgSeleniumTestsWikiUser = 'Wikisysop';
31 -$wgSeleniumTestsWikiPassword = 'password';
32 -
33 -// Common browsers on Windows platform. Modify for other platforms or
34 -// other Windows browsers
35 -// Use the *chrome handler in order to be able to test file uploads
36 -// further solution suggestions: http://www.brokenbuild.com/blog/2007/06/07/testing-file-uploads-with-selenium-rc-and-firefoxor-reducing-javascript-security-in-firefox-for-fun-and-profit/
37 -// $wgSeleniumTestsBrowsers['firefox'] = '*firefox c:\\Program Files (x86)\\Mozilla Firefox\\firefox.exe';
38 -$wgSeleniumTestsBrowsers['firefox'] = '*firefox /usr/bin/firefox';
39 -$wgSeleniumTestsBrowsers['iexplorer'] = '*iexploreproxy';
40 -$wgSeleniumTestsBrowsers['opera'] = '*chrome /usr/bin/opera';
41 -
42 -// Actually, use this browser
43 -$wgSeleniumTestsUseBrowser = 'firefox';
44 -
45 -// Set command line mode
46 -$wgSeleniumTestsRunMode = 'cli';
47 -
48 -// List of tests to be included by default
49 -$wgSeleniumTestIncludes = array(
50 - 'selenium/SimpleSeleniumTest.php'
51 -);
 2+<?php
 3+// This template file contains variables that should be localized.
 4+// The line (specifying the location of the PHP/PEAR libraries) must be
 5+// first. Moving it to a position later in the file will almost certainly
 6+// cause an error.
 7+
 8+// In order to use this file, first copy it to LocalSeleniumSettings.php.
 9+// Then edit the information to conform to the local environment. You
 10+// will almost certainly have to uncomment the line set_include_path ... and
 11+// change the string 'PEAR' to the path to your PEAR library, e.g.,
 12+// '/usr/share/php/PEAR' for a Debian based Linux system.
 13+// The edited file must appear in the same directory as does RunSeleniumTests.php.
 14+
 15+// include path. Set 'PEAR" to '/path/to/PEAR/library'
 16+
 17+// URL: http://localhost/tests/RunSeleniumTests.php
 18+#set_include_path( get_include_path() . PATH_SEPARATOR . 'PEAR' );
 19+
 20+// Hostname of selenium server
 21+$wgSeleniumTestsSeleniumHost = 'localhost';
 22+
 23+// URL of the wiki to be tested. Consult web server configuration.
 24+$wgSeleniumTestsWikiUrl = 'http://localhost';
 25+
 26+// Port used by selenium server (optional - default is 4444)
 27+$wgSeleniumServerPort = 4444;
 28+
 29+// Wiki login. Used by Selenium to log onto the wiki
 30+$wgSeleniumTestsWikiUser = 'Wikisysop';
 31+$wgSeleniumTestsWikiPassword = 'password';
 32+
 33+// Common browsers on Windows platform. Modify for other platforms or
 34+// other Windows browsers
 35+// Use the *chrome handler in order to be able to test file uploads
 36+// further solution suggestions: http://www.brokenbuild.com/blog/2007/06/07/testing-file-uploads-with-selenium-rc-and-firefoxor-reducing-javascript-security-in-firefox-for-fun-and-profit/
 37+// $wgSeleniumTestsBrowsers['firefox'] = '*firefox c:\\Program Files (x86)\\Mozilla Firefox\\firefox.exe';
 38+$wgSeleniumTestsBrowsers['firefox'] = '*firefox /usr/bin/firefox';
 39+$wgSeleniumTestsBrowsers['iexplorer'] = '*iexploreproxy';
 40+$wgSeleniumTestsBrowsers['opera'] = '*chrome /usr/bin/opera';
 41+
 42+// Actually, use this browser
 43+$wgSeleniumTestsUseBrowser = 'firefox';
 44+
 45+// Set command line mode
 46+$wgSeleniumTestsRunMode = 'cli';
 47+
 48+// List of tests to be included by default
 49+$wgSeleniumTestIncludes = array(
 50+ 'selenium/SimpleSeleniumTest.php'
 51+);
5252 ?>
\ No newline at end of file
Property changes on: trunk/phase3/maintenance/tests/selenium/LocalSeleniumSettings.php.sample
___________________________________________________________________
Added: svn:eol-style
5353 + native
Property changes on: trunk/extensions/JS2Support/mwEmbed/tests/selenium_tests/api-proxy.php
___________________________________________________________________
Added: svn:eol-style
5454 + native
Property changes on: trunk/extensions/JS2Support/mwEmbed/tests/selenium_tests/audio-player-menu.php
___________________________________________________________________
Added: svn:eol-style
5555 + native
Property changes on: trunk/extensions/JS2Support/mwEmbed/tests/selenium_tests/player-themable-display.php
___________________________________________________________________
Added: svn:eol-style
5656 + native
Property changes on: trunk/extensions/JS2Support/mwEmbed/tests/selenium_tests/player-timed-text.php
___________________________________________________________________
Added: svn:eol-style
5757 + native
Property changes on: trunk/extensions/JS2Support/mwEmbed/tests/selenium_tests/audio-player-playback-progress.php
___________________________________________________________________
Added: svn:eol-style
5858 + native
Property changes on: trunk/extensions/JS2Support/mwEmbed/tests/selenium_tests/amw-all-providers.php
___________________________________________________________________
Added: svn:eol-style
5959 + native
Property changes on: trunk/extensions/SemanticMediaWiki/libs/jquery-1.4.2.min.js
___________________________________________________________________
Added: svn:eol-style
6060 + native
Property changes on: trunk/extensions/FBConnect/FBConnectUser.php
___________________________________________________________________
Added: svn:eol-style
6161 + native
Property changes on: trunk/extensions/FBConnect/FBConnect.php
___________________________________________________________________
Added: svn:eol-style
6262 + native
Property changes on: trunk/extensions/FBConnect/fbconnect.css
___________________________________________________________________
Added: svn:eol-style
6363 + native
Property changes on: trunk/extensions/FBConnect/FBConnectPushEvent.php
___________________________________________________________________
Added: svn:eol-style
6464 + native
Property changes on: trunk/extensions/FBConnect/FBConnectHooks.php
___________________________________________________________________
Added: svn:eol-style
6565 + native
Property changes on: trunk/extensions/FBConnect/FBConnectDB.php
___________________________________________________________________
Added: svn:eol-style
6666 + native
Property changes on: trunk/extensions/FBConnect/fbconnect.min.js
___________________________________________________________________
Added: svn:eol-style
6767 + native
Property changes on: trunk/extensions/FBConnect/pushEvents/FBPush_OnAddImage.php
___________________________________________________________________
Added: svn:eol-style
6868 + native
Property changes on: trunk/extensions/FBConnect/pushEvents/FBPush_OnLargeEdit.i18n.php
___________________________________________________________________
Added: svn:eol-style
6969 + native
Property changes on: trunk/extensions/FBConnect/pushEvents/FBPush_OnLargeEdit.php
___________________________________________________________________
Added: svn:eol-style
7070 + native
Property changes on: trunk/extensions/FBConnect/pushEvents/FBPush_OnWatchArticle.i18n.php
___________________________________________________________________
Added: svn:eol-style
7171 + native
Property changes on: trunk/extensions/FBConnect/pushEvents/FBPush_OnAddImage.i18n.php
___________________________________________________________________
Added: svn:eol-style
7272 + native
Property changes on: trunk/extensions/FBConnect/pushEvents/FBPush_OnWatchArticle.php
___________________________________________________________________
Added: svn:eol-style
7373 + native
Property changes on: trunk/extensions/FBConnect/FBConnect.i18n.php
___________________________________________________________________
Added: svn:eol-style
7474 + native
Property changes on: trunk/extensions/FBConnect/fbconnect_table.sql
___________________________________________________________________
Added: svn:eol-style
7575 + native
Property changes on: trunk/extensions/FBConnect/php-sdk/facebook.php
___________________________________________________________________
Added: svn:eol-style
7676 + native
Property changes on: trunk/extensions/FBConnect/fbconnect_table.pg.sql
___________________________________________________________________
Added: svn:eol-style
7777 + native
Property changes on: trunk/extensions/FBConnect/fbconnect.js
___________________________________________________________________
Added: svn:eol-style
7878 + native
Property changes on: trunk/extensions/FBConnect/config.default.php
___________________________________________________________________
Added: svn:eol-style
7979 + native
Property changes on: trunk/extensions/FBConnect/FBConnect.alias.php
___________________________________________________________________
Added: svn:eol-style
8080 + native
Property changes on: trunk/extensions/FBConnect/FBConnectXFBML.php
___________________________________________________________________
Added: svn:eol-style
8181 + native
Property changes on: trunk/extensions/FBConnect/SpecialConnect.php
___________________________________________________________________
Added: svn:eol-style
8282 + native
Property changes on: trunk/extensions/FBConnect/FBConnectAPI.php
___________________________________________________________________
Added: svn:eol-style
8383 + native
Property changes on: trunk/extensions/FBConnect/PreferencesExtension.php
___________________________________________________________________
Added: svn:eol-style
8484 + native
Property changes on: trunk/extensions/StrategyWiki/ActiveStrategy/ParserFunctions.php
___________________________________________________________________
Added: svn:eol-style
8585 + native
Property changes on: trunk/extensions/DataTransclusion/DBDataTransclusionSource.php
___________________________________________________________________
Added: svn:eol-style
8686 + native
Property changes on: trunk/extensions/DataTransclusion/DataTransclusion.i18n.php
___________________________________________________________________
Added: svn:eol-style
8787 + native
Property changes on: trunk/extensions/DataTransclusion/DataTransclusionHandler.php
___________________________________________________________________
Added: svn:eol-style
8888 + native
Property changes on: trunk/extensions/DataTransclusion/DataTransclusion.php
___________________________________________________________________
Added: svn:eol-style
8989 + native
Property changes on: trunk/extensions/DataTransclusion/DataTransclusionSource.php
___________________________________________________________________
Added: svn:eol-style
9090 + native

Status & tagging log