r67105 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67104‎ | r67105 | r67106 >
Date:19:17, 30 May 2010
Author:maxsem
Status:ok
Tags:
Comment:
Fixed a few E_DEPRECATED's is ImportXMLReader.php
Modified paths:
  • /trunk/phase3/includes/ImportXMLReader.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ImportXMLReader.php
@@ -376,7 +376,7 @@
377377 $tag = $this->reader->name;
378378
379379 if ( !wfRunHooks( 'ImportHandleLogItemXMLTag',
380 - $this->reader, &$logInfo ) ) {
 380+ $this->reader, $logInfo ) ) {
381381 // Do nothing
382382 } if ( in_array( $tag, $normalFields ) ) {
383383 $logInfo[$tag] = $this->nodeContents();
@@ -437,7 +437,7 @@
438438 // The title is invalid, bail out of this page
439439 $skip = true;
440440 } elseif ( !wfRunHooks( 'ImportHandlePageXMLTag', $this->reader,
441 - &$pageInfo ) ) {
 441+ $pageInfo ) ) {
442442 // Do nothing
443443 } if ( in_array( $tag, $normalFields ) ) {
444444 $pageInfo[$tag] = $this->nodeContents();
@@ -484,7 +484,7 @@
485485 $tag = $this->reader->name;
486486
487487 if ( !wfRunHooks( 'ImportHandleRevisionXMLTag', $this->reader,
488 - &$pageInfo, &$revisionInfo ) ) {
 488+ $pageInfo, $revisionInfo ) ) {
489489 // Do nothing
490490 } if ( in_array( $tag, $normalFields ) ) {
491491 $revisionInfo[$tag] = $this->nodeContents();
@@ -545,7 +545,7 @@
546546 $tag = $this->reader->name;
547547
548548 if ( !wfRunHooks( 'ImportHandleUploadXMLTag', $this->reader,
549 - &$pageInfo, &$revisionInfo ) ) {
 549+ $pageInfo, $revisionInfo ) ) {
550550 // Do nothing
551551 } if ( in_array( $tag, $normalFields ) ) {
552552 $uploadInfo[$tag] = $this->nodeContents();

Status & tagging log