r67052 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r67051‎ | r67052 | r67053 >
Date:19:47, 29 May 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Fixed .attr( 'onclick' vs .click( issue
Modified paths:
  • /trunk/extensions/Storyboard/tags/Storyboard/storyboard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Storyboard/tags/Storyboard/storyboard.js
@@ -63,9 +63,12 @@
6464 $( "<a />" ).attr( {
6565 "target": "_blank",
6666 "rel": "nofollow",
67 - "href": deliciousUrl,
68 - "onclick": "window.open( '" + deliciousUrl + "', 'delicious-sharer', 'toolbar=0, status=0, width=850, height=650' ); return false;"
 67+ "href": deliciousUrl
6968 } )
 69+ .click( function() {
 70+ window.open( jQuery( this ).attr( 'href' ), 'delicious-sharer', 'toolbar=0, status=0, width=850, height=650' );
 71+ return false;
 72+ } )
7073 .append( $( "<img />" ).attr( "src",
7174 wgScriptPath + "/extensions/Storyboard/images/storyboard-delicious.png"
7275 ) )
@@ -76,9 +79,12 @@
7780 $( "<a />" ).attr( {
7881 "target": "_blank",
7982 "rel": "nofollow",
80 - "href": facebookUrl,
81 - "onclick": "window.open( '" + facebookUrl + "', 'facebook-sharer', 'toolbar=0, status=0, width=626, height=436' ); return false;"
 83+ "href": facebookUrl
8284 } )
 85+ .click( function() {
 86+ window.open( jQuery( this ).attr( 'href' ), 'facebook-sharer', 'toolbar=0, status=0, width=626, height=436' );
 87+ return false;
 88+ } )
8389 .append( $( "<img />" ).attr( "src",
8490 wgScriptPath + "/extensions/Storyboard/images/storyboard-facebook.png"
8591 ) )

Status & tagging log