r66945 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66944‎ | r66945 | r66946 >
Date:07:38, 27 May 2010
Author:tstarling
Status:deferred
Tags:
Comment:
MFT r65027: Fixed unwatch links in notification emails sent out via the job queue
Modified paths:
  • /branches/REL1_16/phase3/RELEASE-NOTES (modified) (history)
  • /branches/REL1_16/phase3/includes/UserMailer.php (modified) (history)
  • /branches/REL1_16/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: branches/REL1_16/phase3/includes/UserMailer.php
@@ -472,6 +472,7 @@
473473
474474 $keys['$PAGEMINOREDIT'] = $medit;
475475 $keys['$PAGESUMMARY'] = $summary;
 476+ $keys['$UNWATCHURL'] = $this->title->getFullUrl( 'action=unwatch' );
476477
477478 $subject = strtr( $subject, $keys );
478479
Property changes on: branches/REL1_16/phase3/includes/UserMailer.php
___________________________________________________________________
Name: svn:mergeinfo
479480 + /branches/REL1_15/phase3/includes/UserMailer.php:51646
/branches/sqlite/includes/UserMailer.php:58211-58321
/branches/wmf-deployment/includes/UserMailer.php:53381
/trunk/phase3/includes/UserMailer.php:63549,63764,63897-63901,64876,64881,64948,65027
Index: branches/REL1_16/phase3/languages/messages/MessagesEn.php
@@ -2644,7 +2644,7 @@
26452645 {{fullurl:{{#special:Watchlist}}/edit}}
26462646
26472647 To delete the page from your watchlist, visit
2648 -{{fullurl:{{FULLPAGENAMEE}}|action=unwatch}}
 2648+$UNWATCHURL
26492649
26502650 Feedback and further assistance:
26512651 {{fullurl:{{MediaWiki:Helppage}}}}',
Property changes on: branches/REL1_16/phase3/languages/messages/MessagesEn.php
___________________________________________________________________
Name: svn:mergeinfo
26522652 + /trunk/phase3/languages/messages/MessagesEn.php:63545-63546,63549,63643,63764,63897-63901,64876,65027
Index: branches/REL1_16/phase3/RELEASE-NOTES
@@ -66,6 +66,8 @@
6767 * (bug 23171) Improve IE6 version check to avoid false positives.
6868 * (bug 23176) Fixed upload warning override feature "upload new version",
6969 broken in 1.16 beta 1.
 70+* Fixed regression in unwatch links sent out in notification emails. When the
 71+ mailing job was deferred via the job queue, the title was incorrect.
7072
7173 === Changes since 1.16 beta 1 ===
7274

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r65027Fix regression in unwatch links sent out by enotif. {{FULLPAGENAMEE}} happens...demon14:00, 14 April 2010

Status & tagging log