r66943 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r66942‎ \| r66943 \| r66944 >
Date:	07:19, 27 May 2010
Author:	tstarling
Status:	ok
Tags:
Comment:	Fixed complete breakage of Special:Upload due to r66913. Fatal JS error "summary is null".
Modified paths:	/trunk/phase3/skins/common/edit.js (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/edit.js
—	—	@@ -231,7 +231,10 @@
232	232
233	233	//make sure edit summary does not exceed byte limit
234	234	addOnloadHook(function () {
235		~~- var summary = document.getElementById('wpSummary');~~
	235	+ var summary = document.getElementById( 'wpSummary' );
	236	+ if ( !summary ) {
	237	+ return;
	238	+ }
236	239	summary.maxLength = 250; //L must be capitalized in length.
237	240
238	241	checkSummary = function (e) {

Past revisions this follows-up on

Revision	Commit summary	Author	Date
r66913	(bug 22967) Use javascript to make the maxlength of the edit summary field wo...	bawolff	09:10, 26 May 2010

Status & tagging log

12:53, 6 July 2010 😂 (talk | contribs) changed the status of r66943 [removed: new added: ok]