r66927 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66926‎ | r66927 | r66928 >
Date:15:58, 26 May 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Spatial extensions testing
Modified paths:
  • /trunk/extensions/SemanticMaps/Features/QueryPrinters/SM_MapPrinter.php (modified) (history)
  • /trunk/extensions/SemanticMaps/GeoCoords/SM_GeoCoordsValue.php (modified) (history)
  • /trunk/extensions/SemanticMaps/SM_Settings.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/GeoCoords/SM_GeoCoordsValue.php
@@ -158,7 +158,8 @@
159159 global $smgUseSpatialExtensions, $smgQPCoodFormat, $smgQPCoodDirectional;
160160
161161 if ( $smgUseSpatialExtensions ) {
162 - // TODO
 162+ //die(__METHOD__);
 163+ //var_dump($args);exit;
163164 }
164165 else {
165166 $this->mCoordinateSet['lat'] = $args[0];
@@ -184,6 +185,7 @@
185186
186187 if ( $smgUseSpatialExtensions ) {
187188 $point = str_replace( ',', '.', " POINT({$this->mCoordinateSet['lat']} {$this->mCoordinateSet['lon']}) " );
 189+ //var_dump("GeomFromText( '$point' )");exit;
188190 return array( "GeomFromText( '$point' )" );
189191 }
190192 else {
Index: trunk/extensions/SemanticMaps/SM_Settings.php
@@ -20,7 +20,6 @@
2121
2222
2323
24 -
2524 # Features configuration
2625
2726 # (named) Array of String. This array contains the available features for Maps.
Index: trunk/extensions/SemanticMaps/Features/QueryPrinters/SM_MapPrinter.php
@@ -138,7 +138,6 @@
139139 * @param string $className
140140 */
141141 private function setMapProperties( array $mapProperties, $className ) {
142 - // var_dump($mapProperties); exit;
143142 foreach ( $mapProperties as $paramName => $paramValue ) {
144143 if ( ! property_exists( $className, $paramName ) ) {
145144 $this-> { $paramName } = $paramValue;

Status & tagging log