r66893 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66892‎ | r66893 | r66894 >
Date:20:46, 25 May 2010
Author:reedy
Status:ok
Tags:
Comment:
Remove arrays from getDescription where we are only using 1 line
Modified paths:
  • /trunk/phase3/includes/api/ApiBlock.php (modified) (history)
  • /trunk/phase3/includes/api/ApiDelete.php (modified) (history)
  • /trunk/phase3/includes/api/ApiDisabled.php (modified) (history)
  • /trunk/phase3/includes/api/ApiEmailUser.php (modified) (history)
  • /trunk/phase3/includes/api/ApiGo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiHelp.php (modified) (history)
  • /trunk/phase3/includes/api/ApiImport.php (modified) (history)
  • /trunk/phase3/includes/api/ApiLogout.php (modified) (history)
  • /trunk/phase3/includes/api/ApiMove.php (modified) (history)
  • /trunk/phase3/includes/api/ApiPatrol.php (modified) (history)
  • /trunk/phase3/includes/api/ApiProtect.php (modified) (history)
  • /trunk/phase3/includes/api/ApiPurge.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryImageInfo.php (modified) (history)
  • /trunk/phase3/includes/api/ApiUnblock.php (modified) (history)
  • /trunk/phase3/includes/api/ApiUserrights.php (modified) (history)
  • /trunk/phase3/includes/api/ApiWatch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiWatch.php
@@ -89,9 +89,7 @@
9090 }
9191
9292 public function getDescription() {
93 - return array(
94 - 'Add or remove a page from/to the current user\'s watchlist'
95 - );
 93+ return 'Add or remove a page from/to the current user\'s watchlist';
9694 }
9795
9896 public function getPossibleErrors() {
Index: trunk/phase3/includes/api/ApiMove.php
@@ -221,9 +221,7 @@
222222 }
223223
224224 public function getDescription() {
225 - return array(
226 - 'Move a page'
227 - );
 225+ return 'Move a page';
228226 }
229227
230228 public function getPossibleErrors() {
Index: trunk/phase3/includes/api/ApiLogout.php
@@ -63,9 +63,7 @@
6464 }
6565
6666 public function getDescription() {
67 - return array(
68 - 'This module is used to logout and clear session data'
69 - );
 67+ return 'This module is used to logout and clear session data';
7068 }
7169
7270 protected function getExamples() {
Index: trunk/phase3/includes/api/ApiProtect.php
@@ -193,9 +193,7 @@
194194 }
195195
196196 public function getDescription() {
197 - return array(
198 - 'Change the protection level of a page'
199 - );
 197+ return 'Change the protection level of a page';
200198 }
201199
202200 public function getPossibleErrors() {
Index: trunk/phase3/includes/api/ApiPurge.php
@@ -98,9 +98,7 @@
9999 }
100100
101101 public function getDescription() {
102 - return array(
103 - 'Purge the cache for the given titles'
104 - );
 102+ return 'Purge the cache for the given titles';
105103 }
106104
107105 public function getPossibleErrors() {
Index: trunk/phase3/includes/api/ApiUserrights.php
@@ -115,9 +115,7 @@
116116 }
117117
118118 public function getDescription() {
119 - return array(
120 - 'Add/remove a user to/from groups',
121 - );
 119+ return 'Add/remove a user to/from groups';
122120 }
123121
124122 public function getPossibleErrors() {
Index: trunk/phase3/includes/api/ApiDelete.php
@@ -235,9 +235,7 @@
236236 }
237237
238238 public function getDescription() {
239 - return array(
240 - 'Delete a page'
241 - );
 239+ return 'Delete a page';
242240 }
243241
244242 public function getPossibleErrors() {
Index: trunk/phase3/includes/api/ApiGo.php
@@ -74,9 +74,7 @@
7575 }
7676
7777 public function getDescription() {
78 - return array(
79 - 'Determine the title one will be taken to by a "Go" search, if any'
80 - );
 78+ return 'Determine the title one will be taken to by a "Go" search, if any';
8179 }
8280
8381 public function getPossibleErrors() {
Index: trunk/phase3/includes/api/ApiDisabled.php
@@ -60,9 +60,7 @@
6161 }
6262
6363 public function getDescription() {
64 - return array(
65 - 'This module has been disabled'
66 - );
 64+ return 'This module has been disabled';
6765 }
6866
6967 protected function getExamples() {
Index: trunk/phase3/includes/api/ApiImport.php
@@ -141,9 +141,7 @@
142142 }
143143
144144 public function getDescription() {
145 - return array(
146 - 'Import a page from another wiki, or an XML file'
147 - );
 145+ return 'Import a page from another wiki, or an XML file';
148146 }
149147
150148 public function getPossibleErrors() {
Index: trunk/phase3/includes/api/ApiUnblock.php
@@ -114,9 +114,7 @@
115115 }
116116
117117 public function getDescription() {
118 - return array(
119 - 'Unblock a user'
120 - );
 118+ return 'Unblock a user';
121119 }
122120
123121 public function getPossibleErrors() {
Index: trunk/phase3/includes/api/ApiQueryImageInfo.php
@@ -332,9 +332,7 @@
333333 }
334334
335335 public function getDescription() {
336 - return array(
337 - 'Returns image information and upload history'
338 - );
 336+ return 'Returns image information and upload history';
339337 }
340338
341339 public function getPossibleErrors() {
Index: trunk/phase3/includes/api/ApiEmailUser.php
@@ -109,9 +109,7 @@
110110 }
111111
112112 public function getDescription() {
113 - return array(
114 - 'Email a user.'
115 - );
 113+ return 'Email a user.';
116114 }
117115
118116 public function getPossibleErrors() {
Index: trunk/phase3/includes/api/ApiHelp.php
@@ -130,9 +130,7 @@
131131 }
132132
133133 public function getDescription() {
134 - return array(
135 - 'Display this help screen. Or the help screen for the specified module'
136 - );
 134+ return 'Display this help screen. Or the help screen for the specified module';
137135 }
138136
139137 protected function getExamples() {
Index: trunk/phase3/includes/api/ApiBlock.php
@@ -168,9 +168,7 @@
169169 }
170170
171171 public function getDescription() {
172 - return array(
173 - 'Block a user'
174 - );
 172+ return 'Block a user';
175173 }
176174
177175 public function getPossibleErrors() {
Index: trunk/phase3/includes/api/ApiPatrol.php
@@ -83,9 +83,7 @@
8484 }
8585
8686 public function getDescription() {
87 - return array(
88 - 'Patrol a page or revision'
89 - );
 87+ return 'Patrol a page or revision';
9088 }
9189
9290 public function getPossibleErrors() {

Status & tagging log