r66880 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66879‎ | r66880 | r66881 >
Date:17:04, 25 May 2010
Author:happy-melon
Status:reverted
Tags:
Comment:
Follow-up r66878 per CR.
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -2056,9 +2056,6 @@
20572057 Article::onArticleEdit( $this->mTitle );
20582058 # Update links tables, site stats, etc.
20592059 $this->editUpdates( $text, $summary, $isminor, $now, $revisionId, $changed );
2060 -
2061 - $extraQuery = ''; # Give extensions a chance to modify URL query on update
2062 - wfRunHooks( 'ArticleUpdateBeforeRedirect', array( $this, &$sectionanchor, &$extraQuery ) );
20632060 } else {
20642061 # Create new article
20652062 $status->value['new'] = true;
@@ -2138,20 +2135,23 @@
21392136 &$redirect) );
21402137
21412138 # Watch or unwatch the page
2142 - if ( $watchthis == true) {
 2139+ if ( $watchthis === true ) {
21432140 if ( !$this->mTitle->userIsWatching() ) {
21442141 $dbw->begin();
21452142 $this->doWatch();
21462143 $dbw->commit();
21472144 }
2148 - } elseif ($watchthis == false) {
 2145+ } elseif ( $watchthis === false ) {
21492146 if ( $this->mTitle->userIsWatching() ) {
21502147 $dbw->begin();
21512148 $this->doUnwatch();
21522149 $dbw->commit();
21532150 }
21542151 }
2155 -
 2152+
 2153+ # Give extensions a chance to modify URL query on update
 2154+ $extraQuery = '';
 2155+ wfRunHooks( 'ArticleUpdateBeforeRedirect', array( $this, &$sectionanchor, &$extraQuery ) );
21562156 if ( $redirect ) {
21572157 if ( $sectionanchor || $extraQuery ) {
21582158 $this->doRedirect( $this->isRedirect( $text ), $sectionanchor, $extraQuery );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66878(bug 23641) refactor code around Article::doEdit(), and restored access to wa...happy-melon16:40, 25 May 2010

Status & tagging log