r66850 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66849‎ | r66850 | r66851 >
Date:21:15, 24 May 2010
Author:pdhanda
Status:ok
Tags:
Comment:
Removed the supported browser = true statement i had added for testing :(
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -74,7 +74,7 @@
7575 array( 'src' => 'js/plugins/jquery.expandableField.js', 'version' => 15 ),
7676 array( 'src' => 'js/plugins/jquery.suggestions.js', 'version' => 21 ),
7777 array( 'src' => 'js/plugins/jquery.textSelection.js', 'version' => 33 ),
78 - array( 'src' => 'js/plugins/jquery.wikiEditor.js', 'version' => 188 ),
 78+ array( 'src' => 'js/plugins/jquery.wikiEditor.js', 'version' => 189 ),
7979 array( 'src' => 'js/plugins/jquery.wikiEditor.highlight.js', 'version' => 53 ),
8080 array( 'src' => 'js/plugins/jquery.wikiEditor.toolbar.js', 'version' => 62 ),
8181 array( 'src' => 'js/plugins/jquery.wikiEditor.dialogs.js', 'version' => 24 ),
@@ -85,10 +85,10 @@
8686 array( 'src' => 'js/plugins/jquery.wikiEditor.publish.js', 'version' => 5 ),
8787 ),
8888 'combined' => array(
89 - array( 'src' => 'js/plugins.combined.js', 'version' => 408 ),
 89+ array( 'src' => 'js/plugins.combined.js', 'version' => 409 ),
9090 ),
9191 'minified' => array(
92 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 408 ),
 92+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 409 ),
9393 ),
9494 ),
9595 );
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.wikiEditor.js
@@ -85,7 +85,6 @@
8686 'isSupported': function( module ) {
8787 // Fallback to the wikiEditor browser map if no special map is provided in the module
8888 var mod = module && 'browsers' in module ? module : $.wikiEditor;
89 - return mod.supported = true;
9089 // Check for and make use of cached value and early opportunities to bail
9190 if ( typeof mod.supported !== 'undefined' ) {
9291 // Cache hit
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.js
@@ -6763,7 +6763,6 @@
67646764 'isSupported': function( module ) {
67656765 // Fallback to the wikiEditor browser map if no special map is provided in the module
67666766 var mod = module && 'browsers' in module ? module : $.wikiEditor;
6767 - return mod.supported = true;
67686767 // Check for and make use of cached value and early opportunities to bail
67696768 if ( typeof mod.supported !== 'undefined' ) {
67706769 // Cache hit
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.min.js
@@ -453,7 +453,7 @@
454454 options.endContainer=options.startContainer;break;case'scrollToCaretPosition':options=$.extend({'force':false},options);break;}
455455 var context=$(this).data('wikiEditor-context');var hasIframe=context!==undefined&&context.$iframe!==undefined;var needSave=false;if(hasIframe&&context.savedSelection!==null){context.fn.restoreSelection();needSave=true;}
456456 retval=(hasIframe?context.fn:fn)[command].call(this,options);if(hasIframe&&needSave){context.fn.saveSelection();}
457 -return retval;};})(jQuery);(function($){$.wikiEditor={'modules':{},'instances':[],'browsers':{'ltr':{'msie':[['>=',7]],'firefox':[['>=',2]],'opera':[['>=',9.6]],'safari':[['>=',3]],'chrome':[['>=',3]],'blackberry':false,'ipod':false,'iphone':false},'rtl':{'msie':[['>=',8]],'firefox':[['>=',2]],'opera':[['>=',9.6]],'safari':[['>=',3]],'chrome':[['>=',3]],'blackberry':false,'ipod':false,'iphone':false}},'imgPath':wgScriptPath+'/extensions/UsabilityInitiative/images/wikiEditor/','isSupported':function(module){var mod=module&&'browsers'in module?module:$.wikiEditor;return mod.supported=true;if(typeof mod.supported!=='undefined'){return mod.supported;}
 457+return retval;};})(jQuery);(function($){$.wikiEditor={'modules':{},'instances':[],'browsers':{'ltr':{'msie':[['>=',7]],'firefox':[['>=',2]],'opera':[['>=',9.6]],'safari':[['>=',3]],'chrome':[['>=',3]],'blackberry':false,'ipod':false,'iphone':false},'rtl':{'msie':[['>=',8]],'firefox':[['>=',2]],'opera':[['>=',9.6]],'safari':[['>=',3]],'chrome':[['>=',3]],'blackberry':false,'ipod':false,'iphone':false}},'imgPath':wgScriptPath+'/extensions/UsabilityInitiative/images/wikiEditor/','isSupported':function(module){var mod=module&&'browsers'in module?module:$.wikiEditor;if(typeof mod.supported!=='undefined'){return mod.supported;}
458458 if(!($.browser.name in mod.browsers[$('body').is('.rtl')?'rtl':'ltr'])){return mod.supported=true;}
459459 var browser=mod.browsers[$('body').is('.rtl')?'rtl':'ltr'][$.browser.name];if(typeof browser!='object'){return mod.supported=false;}
460460 for(var condition in browser){var op=browser[condition][0];var val=browser[condition][1];if(val===false){return mod.supported=false;}else if(typeof val=='string'){if(!(eval('$.browser.version'+op+'"'+val+'"'))){return mod.supported=false;}}else if(typeof val=='number'){if(!(eval('$.browser.versionNumber'+op+val))){return mod.supported=false;}}}

Status & tagging log