r66828 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66827‎ | r66828 | r66829 >
Date:14:12, 24 May 2010
Author:ialex
Status:ok
Tags:
Comment:
Cosmetic in head scripts
* add a new line before including wikibits.js
* don't add a new line between getHeadScripts() and getHeadItems()
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -2138,8 +2138,7 @@
21392139 $ret .= implode( "\n", array(
21402140 $this->getHeadLinks(),
21412141 $this->buildCssLinks(),
2142 - $this->getHeadScripts( $sk ),
2143 - $this->getHeadItems(),
 2142+ $this->getHeadScripts( $sk ) . $this->getHeadItems(),
21442143 ) );
21452144 if ( $sk->usercss ) {
21462145 $ret .= Html::inlineStyle( $sk->usercss );
@@ -2202,7 +2201,7 @@
22032202 global $wgUser, $wgRequest, $wgJsMimeType, $wgUseSiteJs;
22042203 global $wgStylePath, $wgStyleVersion;
22052204
2206 - $scripts = Skin::makeGlobalVariablesScript( $sk->getSkinName() );
 2205+ $scripts = Skin::makeGlobalVariablesScript( $sk->getSkinName() ) . "\n";
22072206 $scripts .= Html::linkedScript( "{$wgStylePath}/common/wikibits.js?$wgStyleVersion" );
22082207
22092208 // add site JS if enabled

Status & tagging log