r66718 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66717‎ | r66718 | r66719 >
Date:05:20, 21 May 2010
Author:tstarling
Status:ok
Tags:
Comment:
Pivot the interpretation of expiry time at 10 years (1980) instead of 1 month.
Modified paths:
  • /trunk/phase3/includes/BagOStuff.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/BagOStuff.php
@@ -154,7 +154,7 @@
155155 * Convert an optionally relative time to an absolute time
156156 */
157157 protected function convertExpiry( $exptime ) {
158 - if ( ( $exptime != 0 ) && ( $exptime < 3600 * 24 * 30 ) ) {
 158+ if ( ( $exptime != 0 ) && ( $exptime < 86400 * 3650 /* 10 years */ ) ) {
159159 return time() + $exptime;
160160 } else {
161161 return $exptime;

Status & tagging log