r66693 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r66692‎ | r66693 | r66694 >
Date:14:08, 20 May 2010
Author:platonides
Status:ok
Tags:
Comment:
(Bug 23600) Use single quotes for the string on SQL.
On Postgres text is quoted by single quotes and double quotes
are used for identifiers.
Thus Postgres gives out the error "Column upload does not exist".
Modified paths:
  • /trunk/extensions/Nuke/Nuke_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Nuke/Nuke_body.php
——@@ -122,7 +122,7 @@
123123 array( 'rc_namespace', 'rc_title', 'rc_timestamp', 'COUNT(*) AS edits' ),
124124 array(
125125 'rc_user_text' => $username,
126 - '(rc_new = 1) OR (rc_log_type = "upload" AND rc_log_action = "upload")'
 126+ "(rc_new = 1) OR (rc_log_type = 'upload' AND rc_log_action = 'upload')"
127127 ),
128128 __METHOD__,
129129 array(

Status & tagging log