r66647 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66646‎ | r66647 | r66648 >
Date:19:08, 19 May 2010
Author:yaron
Status:deferred
Tags:
Comment:
Set FCKeditor to use the global $wgFCKEditorHeight variable, if it's there
Modified paths:
  • /trunk/extensions/SemanticForms/includes/SF_FormUtils.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/includes/SF_FormUtils.php
@@ -796,7 +796,14 @@
797797 if ( realTextarea )
798798 {
799799 // Create the editor instance and replace the textarea.
800 - oFCKeditor.Height = 300;
 800+ var height = $wgFCKEditorHeight;
 801+ if (height == 0) {
 802+ // the original onLoadFCKEditor() has a bunch of
 803+ // browser-based calculations here, but let's just
 804+ // keep it simple
 805+ height = 300;
 806+ }
 807+ oFCKeditor.Height = height;
801808 oFCKeditor.ReplaceTextarea() ;
802809
803810 FCKeditorInsertTags = function (tagOpen, tagClose, sampleText, oDoc)

Status & tagging log