r66632 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66631‎ | r66632 | r66633 >
Date:23:41, 18 May 2010
Author:papyromancer
Status:deferred
Tags:
Comment:
* Sequencer and TimedText updated for Closure
* remaining closure warning lines commented, signed, "-papy"
* This code passes Selenium Full Test Suite
Modified paths:
  • /branches/MwEmbedStandAlone/modules/Sequencer/mw.Sequencer.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/Sequencer/mw.TimedEffectsEdit.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/Sequencer/playlistEmbed.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/TimedText/mw.TimedText.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/TimedText/mw.TimedTextEdit.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/TimedText/remotes/RemoteMwTimedText.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/Sequencer/mw.TimedEffectsEdit.js
@@ -34,8 +34,8 @@
3535 'pSeq': null,
3636
3737 // The requested edit action
38 - 'edit_action': null,
39 -};
 38+ 'edit_action': null
 39+}
4040
4141 mw.TimedEffectsEdit = function( options ) {
4242 return this.init( options );
Index: branches/MwEmbedStandAlone/modules/Sequencer/mw.Sequencer.js
@@ -1537,7 +1537,7 @@
15381538 this.plObj.ctrlBuilder.addControlHooks( $j( '#' + this.timeline_id + '_pl_control' ) );
15391539
15401540 // render out the "jump" div
1541 - if ( this.timeline_mode == 'time' ) {
 1541+ if ( this.timeline_mode == 'time' ) { // Closure reports this line as inactive -papy
15421542 /*$j('#'+this.timeline_id+'_head_jump').width(pixle_length);
15431543 //output times every 50pixles
15441544 var out='';
Index: branches/MwEmbedStandAlone/modules/Sequencer/playlistEmbed.js
@@ -26,7 +26,7 @@
2727 'fullscreen': false,
2828 'time_display': true,
2929 'volume_control': true,
30 - 'overlays': true,
 30+ 'overlays': true
3131 },
3232
3333 /**
@@ -64,4 +64,4 @@
6565 getClipsInRange: function( range ) {
6666
6767 }
68 -}
\ No newline at end of file
 68+}
Index: branches/MwEmbedStandAlone/modules/TimedText/mw.TimedText.js
@@ -399,10 +399,9 @@
400400
401401 /**
402402 * Checks if a source is "on"
403 - * @return
 403+ * @return {Boolean}
404404 * true if source is on
405405 * false if source is off
406 - * @type {Boolean}
407406 */
408407 isSourceEnabled: function( source ) {
409408 for(var i in this.enabledSources ) {
@@ -860,7 +859,7 @@
861860 * with some timedText features
862861 *
863862 * @param {Object} source Source object to extend
864 - * @param {Object} {Optional} textProvider The text provider interface ( to load source from api )
 863+ * @param {Object} textProvider [Optional] The text provider interface ( to load source from api )
865864 */
866865 TextSource = function( source , textProvider) {
867866 return this.init( source, textProvider );
@@ -1193,7 +1192,7 @@
11941193
11951194 /**
11961195 * Loads a single text source by titleKey
1197 - * @param {titleKey}
 1196+ * @param {Object} titleKey
11981197 */
11991198 loadTitleKey: function( titleKey, callback ) {
12001199 var request = {
@@ -1366,4 +1365,4 @@
13671366 }
13681367 } );
13691368 }
1370 -} )( jQuery );
\ No newline at end of file
 1369+} )( jQuery );
Index: branches/MwEmbedStandAlone/modules/TimedText/mw.TimedTextEdit.js
@@ -136,8 +136,7 @@
137137
138138 /**
139139 * Creates an interface for a given stage id
140 - * @return the jquery interface
141 - * @type {Object}
 140+ * @return {Object} the jquery interface
142141 */
143142 createInterface: function( edit_stage_id) {
144143 $target = $j('#tab-' + edit_stage_id);
Index: branches/MwEmbedStandAlone/modules/TimedText/remotes/RemoteMwTimedText.js
@@ -127,7 +127,7 @@
128128 /**
129129 * Gets the properties of a given title as a resource
130130 * @param {String} fileTitle Title of media asset to embed
131 - * @param {Function} {Optional} callback Function to call once asset is embedded
 131+ * @param {Function} callback [Optional] Function to call once asset is embedded
132132 */
133133 getTitleResource: function( fileTitle, callback ) {
134134 var _this = this;
@@ -181,7 +181,7 @@
182182 'poster' : page.imageinfo[0].thumburl,
183183 'src' : page.imageinfo[0].url,
184184 'width' : page.imageinfo[0].width,
185 - 'height': page.imageinfo[0].height,
 185+ 'height': page.imageinfo[0].height
186186 };
187187 }
188 -};
\ No newline at end of file
 188+};

Status & tagging log