r66601 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66600‎ | r66601 | r66602 >
Date:03:44, 18 May 2010
Author:tstarling
Status:ok
Tags:
Comment:
MFT r63935: Fix reference to lazy-initialised global $wgLanguageNames
Modified paths:
  • /branches/wmf/1.16wmf4/maintenance (modified) (history)
  • /branches/wmf/1.16wmf4/maintenance/addwiki.php (modified) (history)

Diff [purge]

Index: branches/wmf/1.16wmf4/maintenance/addwiki.php
@@ -43,17 +43,18 @@
4444 }
4545
4646 public function execute() {
47 - global $IP, $wgLanguageNames, $wgDefaultExternalStore, $wgNoDBParam;
 47+ global $IP, $wgDefaultExternalStore, $wgNoDBParam;
4848
4949 $wgNoDBParam = true;
5050 $lang = $this->getArg(0);
5151 $site = $this->getArg(1);
5252 $dbName = $this->getArg(2);
 53+ $languageNames = Language::getLanguageNames();
5354
54 - if ( !isset( $wgLanguageNames[$lang] ) ) {
 55+ if ( !isset( $languageNames[$lang] ) ) {
5556 $this->error( "Language $lang not found in \$wgLanguageNames", true );
5657 }
57 - $name = $wgLanguageNames[$lang];
 58+ $name = $languageNames[$lang];
5859
5960 $dbw = wfGetDB( DB_MASTER );
6061 $common = "/home/wikipedia/common";
Property changes on: branches/wmf/1.16wmf4/maintenance
___________________________________________________________________
Name: svn:mergeinfo
6162 + /branches/wmf-deployment/maintenance:60970
/trunk/phase3/maintenance:63545-63546,63549,63643,63764,63897-63901,63935,64113,64509,65387,65391,65555,65590,65650,65816

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r63935Fix reference to lazy-initialised global $wgLanguageNames.tstarling22:15, 18 March 2010

Status & tagging log