r66586 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66585‎ | r66586 | r66587 >
Date:20:16, 17 May 2010
Author:dale
Status:deferred
Tags:
Comment:
* removed depreciated $wgEnableScriptMinify global ( handled via wgScriptDebug flag )
Modified paths:
  • /trunk/extensions/JS2Support/mwEmbed/jsScriptLoader.php (modified) (history)

Diff [purge]

Index: trunk/extensions/JS2Support/mwEmbed/jsScriptLoader.php
@@ -84,8 +84,7 @@
8585 * outputs js
8686 */
8787 function doScriptLoader() {
88 - global $wgScriptLoaderNamedPaths, $IP,
89 - $wgEnableScriptMinify, $wgUseFileCache;
 88+ global $wgScriptLoaderNamedPaths, $IP, $wgUseFileCache;
9089
9190 // Load the javascript class paths:
9291 require_once( realpath( dirname( __FILE__ ) ) . "/includes/jsClassLoader.php");
@@ -504,7 +503,7 @@
505504 * validate classes and generate request key
506505 */
507506 function postProcRequestVars(){
508 - global $wgContLanguageCode, $wgEnableScriptMinify, $wgScriptLoaderNamedPaths,
 507+ global $wgContLanguageCode, $wgScriptLoaderNamedPaths,
509508 $wgStyleVersion;
510509
511510 // Set debug flag
@@ -585,11 +584,7 @@
586585
587586 // Add the unique rid
588587 $this->requestKey .= $this->urid;
589 -
590 - // Add a minify flag
591 - if ( $wgEnableScriptMinify ) {
592 - $this->requestKey .= '_min';
593 - }
 588+
594589 }
595590 /**
596591 * Pre-process request variables ~without configuration~ or any utility functions.

Status & tagging log