r66567 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r66566‎ | r66567 | r66568 >
Date:15:18, 17 May 2010
Author:hartman
Status:deferred
Tags:
Comment:
Follow up r66505
Remove the width setting alltogether. It serves no purpose, and when there ARE problems, not having min-width makes it easier to spot these problems.
Modified paths:
  • /trunk/extensions/OggHandler/OggHandler_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/OggHandler/OggHandler_body.php
——@@ -602,9 +602,7 @@
603603 'isVideo' => $this->isVideo ) );
604604
605605 $s = Xml::tags( 'div',
606 - array(
607 - 'id' => $id,
608 - 'style' => "min-width: {$width}px;" ),
 606+ array( 'id' => $id ),
609607 ( $thumb ? Xml::tags( 'div', array(), $thumb ) : '' ) .
610608 Xml::tags( 'div', array(),
611609 Xml::tags( 'button',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66505Change the width of the div surrouding mediaplayers into min-width...hartman00:26, 16 May 2010

Status & tagging log