r66554 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66553‎ | r66554 | r66555 >
Date:01:05, 17 May 2010
Author:yaron
Status:deferred
Tags:
Comment:
Simplified, added check for cacheSMWPageID() method, for use with the Triple Store Connector, which doesn't have that method
Modified paths:
  • /trunk/extensions/SemanticDrilldown/specials/SD_BrowseData.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticDrilldown/specials/SD_BrowseData.php
@@ -1088,9 +1088,10 @@
10891089 $store = smwfGetStore();
10901090 while ( ( $count < $num ) && ( $row = $dbr->fetchObject( $res ) ) ) {
10911091 $count++;
1092 - $v = SMWWikiPageValue::makePage( $row->t, $row->ns, $row->sortkey );
1093 - $qr[] = $v;
1094 - $store->cacheSMWPageID( $row->id, $row->t, $row->ns, $row->iw );
 1092+ $qr[] = SMWWikiPageValue::makePage( $row->t, $row->ns, $row->sortkey );
 1093+ if ( method_exists( $store, 'cacheSMWPageID' ) ) {
 1094+ $store->cacheSMWPageID( $row->id, $row->t, $row->ns, $row->iw );
 1095+ }
10951096 }
10961097 if ( $dbr->fetchObject( $res ) ) {
10971098 $count++;

Status & tagging log