r66550 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66549‎ | r66550 | r66551 >
Date:22:03, 16 May 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.3
Modified paths:
  • /trunk/extensions/Validator/Validator.class.php (modified) (history)
  • /trunk/extensions/Validator/Validator.i18n.php (modified) (history)
  • /trunk/extensions/Validator/Validator.php (modified) (history)
  • /trunk/extensions/Validator/Validator_Formats.php (modified) (history)
  • /trunk/extensions/Validator/Validator_Manager.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Validator/Validator.class.php
@@ -21,7 +21,6 @@
2222 * @author Jeroen De Dauw
2323 *
2424 * TODO: break on fatal errors, such as missing required parameters that are dependencies
25 - *
2625 * TODO: correct invalid parameters in the main loop, as to have correct dependency handling
2726 */
2827 final class Validator {
Index: trunk/extensions/Validator/Validator_Manager.php
@@ -21,7 +21,6 @@
2222 * @author Jeroen De Dauw
2323 *
2424 * FIXME: missing required params should result in a no-go, no matter of the error level, as they can/are not defaulted.
25 - *
2625 * TODO: make a distinction between fatal errors and regular errors by using 2 seperate error levels.
2726 */
2827 final class ValidatorManager {
Index: trunk/extensions/Validator/Validator_Formats.php
@@ -33,7 +33,7 @@
3434 }
3535
3636 /**
37 - * Ensures the value is an array.
 37+ * Returns an array containing only the specified values.
3838 *
3939 * @param $value
4040 * @param string name The name of the parameter.
Index: trunk/extensions/Validator/Validator.i18n.php
@@ -16,7 +16,7 @@
1717 */
1818 $messages['en'] = array(
1919 'validator_name' => 'Validator',
20 - 'validator-desc' => 'Validator provides an easy way for other extensions to validate parameters of parser functions and tag extensions, set default values and generate error messages',
 20+ 'validator-desc' => 'Validator is a MediaWiki extension that provides generic parameter handling support to other extensions',
2121
2222 'validator_error_parameters' => 'The following {{PLURAL:$1|error has|errors have}} been detected in your syntax:',
2323 'validator_warning_parameters' => 'There {{PLURAL:$1|is an error|are errors}} in your syntax.',
Index: trunk/extensions/Validator/Validator.php
@@ -24,7 +24,7 @@
2525 die( 'Not an entry point.' );
2626 }
2727
28 -define( 'Validator_VERSION', '0.3 rc2' );
 28+define( 'Validator_VERSION', '0.3' );
2929
3030 // Constants indicating the strictness of the parameter validation.
3131 define( 'Validator_ERRORS_NONE', 0 );

Status & tagging log