r66435 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66434‎ | r66435 | r66436 >
Date:19:33, 14 May 2010
Author:aaron
Status:ok
Tags:
Comment:
* Load CSS for ProblemChanges
* Utilize CSS for font style
* Cleaned up cache key check
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/client/flaggedrevs.css (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/OldReviewedPages_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/specialpages/OldReviewedPages_body.php
@@ -253,9 +253,9 @@
254254 }
255255 $key = wfMemcKey( 'stableDiffs', 'underReview', $row->stable, $row->page_latest );
256256 # Show if a user is looking at this page
257 - if ( ( $val = $wgMemc->get( $key ) ) ) {
258 - $underReview = " <b class='fr-under-review'>" .
259 - wfMsgHtml( 'oldreviewedpages-viewing' ) . '</b>';
 257+ if ( $wgMemc->get( $key ) ) {
 258+ $underReview = ' <span class="fr-under-review">' .
 259+ wfMsgHtml( 'oldreviewedpages-viewing' ) . '</span>';
260260 }
261261
262262 return( "<li{$css}>{$link} ({$hist}) {$stxt} ({$review}) <i>{$age}</i>" .
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.hooks.php
@@ -121,8 +121,8 @@
122122 if ( empty( $wgTitle ) || $wgTitle->getNamespace() !== NS_SPECIAL ) {
123123 return true;
124124 }
125 - $spPages = array( 'UnreviewedPages', 'OldReviewedPages', 'Watchlist',
126 - 'Recentchanges', 'Contributions' );
 125+ $spPages = array( 'UnreviewedPages', 'OldReviewedPages', 'ProblemChanges',
 126+ 'Watchlist', 'Recentchanges', 'Contributions' );
127127 foreach ( $spPages as $n => $key ) {
128128 if ( $wgTitle->isSpecial( $key ) ) {
129129 global $wgScriptPath, $wgFlaggedRevsStylePath, $wgFlaggedRevStyleVersion;
Index: trunk/extensions/FlaggedRevs/client/flaggedrevs.css
@@ -260,8 +260,9 @@
261261 background-color: #faebd7;
262262 }
263263
264 -.fr-under-review {
 264+span.fr-under-review {
265265 background-color: yellow;
 266+ font-weight: bold;
266267 }
267268
268269 .mw-fr-reviewlink {

Status & tagging log