r66356 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66355‎ | r66356 | r66357 >
Date:16:11, 13 May 2010
Author:siebrand
Status:deferred
Tags:
Comment:
Add FIXMEs because of conflicting magic words with those used in OggHandler.
Modified paths:
  • /trunk/extensions/TimedMediaHandler/TimedMediaHandler.i18n.magic.php (modified) (history)

Diff [purge]

Index: trunk/extensions/TimedMediaHandler/TimedMediaHandler.i18n.magic.php
@@ -8,9 +8,9 @@
99 $magicWords = array();
1010
1111 $magicWords['en'] = array(
12 - 'ogg_noplayer' => array( 0, 'noplayer' ),
13 - 'ogg_noicon' => array( 0, 'noicon' ),
14 - 'ogg_thumbtime' => array( 0, 'thumbtime=$1' ),
 12+ 'ogg_noplayer' => array( 0, 'noplayer' ), // FIXME: conflicts with magic word in OggHandler
 13+ 'ogg_noicon' => array( 0, 'noicon' ), // FIXME: conflicts with magic word in OggHandler
 14+ 'ogg_thumbtime' => array( 0, 'thumbtime=$1' ), // FIXME: conflicts with magic word in OggHandler
1515 'ogg_starttime' => array( 0, 'start=$1'),
1616 'ogg_endtime' => array( 0, 'end=$1'),
1717 );

Status & tagging log