r66353 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66352‎ | r66353 | r66354 >
Date:15:09, 13 May 2010
Author:tstarling
Status:ok
Tags:
Comment:
Avoid E_NOTICE when texttop or textaftersummary is not specified. To support extensions such as UploadWizard. Patch by Michael Dale.
Modified paths:
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -732,9 +732,12 @@
733733 $this->mHideIgnoreWarning = !empty( $options['hideignorewarning'] );
734734 $this->mDestWarningAck = !empty( $options['destwarningack'] );
735735
736 - $this->mTextTop = $options['texttop'];
737 - $this->mTextAfterSummary = $options['textaftersummary'];
 736+ $this->mTextTop = isset( $options['texttop'] )
 737+ ? $options['texttop'] : '';
738738
 739+ $this->mTextAfterSummary = isset( $options['textaftersummary'] )
 740+ ? $options['textaftersummary'] : '';
 741+
739742 $sourceDescriptor = $this->getSourceSection();
740743 $descriptor = $sourceDescriptor
741744 + $this->getDescriptionSection()

Status & tagging log