r66302 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66301‎ | r66302 | r66303 >
Date:21:13, 12 May 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Maps & SM 0.6 rc2, Validator 0.3 rc2
Modified paths:
  • /trunk/extensions/Maps/Maps.php (modified) (history)
  • /trunk/extensions/SemanticMaps/GeoCoords/SM_AreaValueDescription.php (modified) (history)
  • /trunk/extensions/SemanticMaps/GeoCoords/SM_GeoCoordsValue.php (modified) (history)
  • /trunk/extensions/SemanticMaps/SemanticMaps.php (modified) (history)
  • /trunk/extensions/Validator/Validator.class.php (modified) (history)
  • /trunk/extensions/Validator/Validator.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/GeoCoords/SM_GeoCoordsValue.php
@@ -265,4 +265,4 @@
266266 return array( 0, 1 );
267267 }
268268
269 -}
 269+}
\ No newline at end of file
Index: trunk/extensions/SemanticMaps/GeoCoords/SM_AreaValueDescription.php
@@ -39,6 +39,8 @@
4040
4141 $ratio = array(
4242 'km' => 1000,
 43+ 'kilometers' => 1000,
 44+ 'kilometres' => 1000,
4345 'mile' => 1609.344,
4446 'miles' => 1609.344,
4547 'nautical mile' => 1852,
Index: trunk/extensions/SemanticMaps/SemanticMaps.php
@@ -35,7 +35,7 @@
3636
3737 // Only initialize the extension when all dependencies are present.
3838 if ( defined( 'Maps_VERSION' ) && defined( 'SMW_VERSION' ) ) {
39 - define( 'SM_VERSION', '0.6 a26' );
 39+ define( 'SM_VERSION', '0.6 rc2' );
4040
4141 $smgScriptPath = ( isset( $wgExtensionAssetsPath ) && $wgExtensionAssetsPath ? $wgExtensionAssetsPath : $wgScriptPath . '/extensions' ) . '/SemanticMaps';
4242 $smgDir = dirname( __FILE__ ) . '/';
Index: trunk/extensions/Validator/Validator.class.php
@@ -160,7 +160,7 @@
161161 if ( count( $defaultParams ) > 0 ) {
162162 $defaultParam = array_shift( $defaultParams );
163163 $parameters[$defaultParam] = array(
164 - 'original-value' => trim( $parts[0] ),
 164+ 'original-value' => trim( $parts[0] ),
165165 'default' => $defaultNr,
166166 'position' => $nr
167167 );
Index: trunk/extensions/Validator/Validator.php
@@ -24,7 +24,7 @@
2525 die( 'Not an entry point.' );
2626 }
2727
28 -define( 'Validator_VERSION', '0.3 a6' );
 28+define( 'Validator_VERSION', '0.3 rc2' );
2929
3030 // Constants indicating the strictness of the parameter validation.
3131 define( 'Validator_ERRORS_NONE', 0 );
Index: trunk/extensions/Maps/Maps.php
@@ -33,7 +33,7 @@
3434 echo '<b>Warning:</b> You need to have <a href="http://www.mediawiki.org/wiki/Extension:Validator">Validator</a> installed in order to use <a href="http://www.mediawiki.org/wiki/Extension:Maps">Maps</a>.';
3535 }
3636 else {
37 - define( 'Maps_VERSION', '0.6 a26' );
 37+ define( 'Maps_VERSION', '0.6 rc2' );
3838
3939 // The different coordinate notations.
4040 define( 'Maps_COORDS_FLOAT', 'float' );

Status & tagging log