r66162 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66161‎ | r66162 | r66163 >
Date:21:18, 10 May 2010
Author:tparscal
Status:ok
Tags:
Comment:
I really shouldn't code while I'm feeling under the weather... This fixes an incomplete/incoherent comment.
Modified paths:
  • /trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins.combined.js (modified) (history)
  • /trunk/extensions/UsabilityInitiative/js/plugins/jquery.suggestions.js (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/UsabilityInitiative.hooks.php
@@ -70,7 +70,7 @@
7171 array( 'src' => 'js/plugins/jquery.color.js', 'version' => 1 ),
7272 array( 'src' => 'js/plugins/jquery.cookie.js', 'version' => 4 ),
7373 array( 'src' => 'js/plugins/jquery.delayedBind.js', 'version' => 1 ),
74 - array( 'src' => 'js/plugins/jquery.suggestions.js', 'version' => 12 ),
 74+ array( 'src' => 'js/plugins/jquery.suggestions.js', 'version' => 13 ),
7575 array( 'src' => 'js/plugins/jquery.textSelection.js', 'version' => 30 ),
7676 array( 'src' => 'js/plugins/jquery.wikiEditor.js', 'version' => 185 ),
7777 array( 'src' => 'js/plugins/jquery.wikiEditor.highlight.js', 'version' => 53 ),
@@ -83,10 +83,10 @@
8484 array( 'src' => 'js/plugins/jquery.wikiEditor.publish.js', 'version' => 5 ),
8585 ),
8686 'combined' => array(
87 - array( 'src' => 'js/plugins.combined.js', 'version' => 390 ),
 87+ array( 'src' => 'js/plugins.combined.js', 'version' => 391 ),
8888 ),
8989 'minified' => array(
90 - array( 'src' => 'js/plugins.combined.min.js', 'version' => 390 ),
 90+ array( 'src' => 'js/plugins.combined.min.js', 'version' => 391 ),
9191 ),
9292 ),
9393 );
Index: trunk/extensions/UsabilityInitiative/js/plugins/jquery.suggestions.js
@@ -189,7 +189,7 @@
190190 // No item selected, go to the first one
191191 result = context.data.$container.find( '.suggestions-results div:first' );
192192 if ( result.length == 0 && context.data.$container.find( '.suggestions-special' ).html() != "" ) {
193 - // No suggestion exists, use the
 193+ // No suggestion exists, go to the special one directly
194194 result = context.data.$container.find( '.suggestions-special' );
195195 }
196196 } else {
Index: trunk/extensions/UsabilityInitiative/js/plugins.combined.js
@@ -5940,7 +5940,7 @@
59415941 // No item selected, go to the first one
59425942 result = context.data.$container.find( '.suggestions-results div:first' );
59435943 if ( result.length == 0 && context.data.$container.find( '.suggestions-special' ).html() != "" ) {
5944 - // No suggestion exists, use the
 5944+ // No suggestion exists, go to the special one directly
59455945 result = context.data.$container.find( '.suggestions-special' );
59465946 }
59475947 } else {

Status & tagging log