r66156 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66155‎ | r66156 | r66157 >
Date:20:19, 10 May 2010
Author:ialex
Status:deferred
Tags:
Comment:
* Added $wgCommandLineDarkBg, $wgDBadminuser, $wgDBadminpassword
* Reordered a bit database settings
Modified paths:
  • /trunk/extensions/Configure/CHANGELOG (modified) (history)
  • /trunk/extensions/Configure/Configure.php (modified) (history)
  • /trunk/extensions/Configure/handler/HandlerDb.php (modified) (history)
  • /trunk/extensions/Configure/settings/Settings-core.php (modified) (history)
  • /trunk/extensions/Configure/settings/Settings.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/CHANGELOG
@@ -1,6 +1,9 @@
22 This file lists changes on this extension. Localisation updates are done
33 through translatewiki.net and are not listed here.
44
 5+0.15.26 - 10 May 2010
 6+ Added $wgCommandLineDarkBg, $wgDBadminuser, $wgDBadminpassword.
 7+
58 0.15.25 - 9 May 2010
69 $wgSQLiteDataDirMode removed in MediaWiki 1.17.
710
Index: trunk/extensions/Configure/settings/Settings.i18n.php
@@ -19,10 +19,12 @@
2020 'configure-setting-wgDBerrorLog' => 'File to log database errors to',
2121 'configure-setting-wgDBname' => 'Name of the database to use',
2222 'configure-setting-wgDBpassword' => 'Password for $wgDBuser',
 23+ 'configure-setting-wgDBadminpassword' => 'Password for $wgDBadminuser',
2324 'configure-setting-wgDBport' => 'Port for the database server',
2425 'configure-setting-wgDBserver' => 'Host name or IP address of database server',
2526 'configure-setting-wgDBtype' => 'Type of database to use',
2627 'configure-setting-wgDBuser' => 'Username to log into database with',
 28+ 'configure-setting-wgDBadminuser' => 'Username of database administrator',
2729 'configure-setting-wgLocalDatabases' => 'Other databases which can be administered from this server',
2830 'configure-setting-wgSearchType' => 'Type of database search to use. Set to a class name to override to a custom search engine',
2931 'configure-setting-wgSharedDB' => 'Shared database name',
Index: trunk/extensions/Configure/settings/Settings-core.php
@@ -38,6 +38,7 @@
3939 'wgUseAutomaticEditSummaries' => 'bool',
4040 'wgUseTagFilter' => 'bool',
4141 'wgUseTrackbacks' => 'bool',
 42+ 'wgCommandLineDarkBg' => 'bool',
4243 ),
4344 'ajax' => array(
4445 'wgUseAjax' => 'bool',
@@ -170,23 +171,23 @@
171172 ),
172173 'db' => array(
173174 'db' => array(
174 - 'wgAllDBsAreLocalhost' => 'bool',
175 - 'wgDBAvgStatusPoll' => 'int',
176 -# 'wgDBconnection' => 'text', # This setting is deprecated and has an uncertain history. Best not to let people change it.
177 - 'wgDBerrorLog' => 'text',
 175+ 'wgDBtype' => array( 'mysql' => 'MySQL', 'postgres' => 'PostreSQL' ),
178176 'wgDBname' => 'text',
 177+ 'wgDBuser' => 'text',
179178 'wgDBpassword' => 'text',
 179+ 'wgDBadminuser' => 'text',
 180+ 'wgDBadminpassword' => 'text',
 181+ 'wgDBserver' => 'text',
180182 'wgDBport' => 'int',
181 - 'wgDBserver' => 'text',
182 - 'wgDBtype' => array( 'mysql' => 'MySQL', 'postgres' => 'PostreSQL' ),
183 - 'wgDBuser' => 'text',
184 -# 'wgLegacySchemaConversion' => 'bool', # Really, really deprecated.
185183 'wgLocalDatabases' => 'array',
186184 'wgSearchType' => 'text',
187185 'wgSharedDB' => 'text',
188186 'wgSharedPrefix' => 'text',
189187 'wgSharedTables' => 'array',
 188+ 'wgDBerrorLog' => 'text',
190189 'wgAntiLockFlags' => 'int',
 190+ 'wgAllDBsAreLocalhost' => 'bool',
 191+ 'wgDBAvgStatusPoll' => 'int',
191192 'wgUseDumbLinkUpdate' => 'bool',
192193 'wgExternalStores' => 'array',
193194 ),
@@ -1047,6 +1048,7 @@
10481049 'wgDBmysql5',
10491050 'wgDBname',
10501051 'wgDBpassword',
 1052+ 'wgDBadminpassword',
10511053 'wgDBport',
10521054 'wgDBprefix',
10531055 'wgDBserver',
@@ -1056,6 +1058,7 @@
10571059 'wgDBts2schema',
10581060 'wgDBtype',
10591061 'wgDBuser',
 1062+ 'wgDBadminuser',
10601063 'wgDefaultExternalStore',
10611064 'wgExternalStores',
10621065 'wgLBFactoryConf',
@@ -1127,6 +1130,7 @@
11281131 $viewRestricted = array(
11291132 # Db
11301133 'wgDBpassword',
 1134+ 'wgDBadminpassword',
11311135 'wgDBservers',
11321136 'wgLBFactoryConf',
11331137 'wgExternalServers',
Index: trunk/extensions/Configure/Configure.php
@@ -17,7 +17,7 @@
1818 'author' => array( 'Alexandre Emsenhuber', 'Andrew Garrett' ),
1919 'url' => 'http://www.mediawiki.org/wiki/Extension:Configure',
2020 'descriptionmsg' => 'configure-desc',
21 - 'version' => '0.15.25',
 21+ 'version' => '0.15.26',
2222 );
2323
2424 # Configuration part
Index: trunk/extensions/Configure/handler/HandlerDb.php
@@ -333,6 +333,8 @@
334334 'wgDBerrorLog',
335335 'wgDBname',
336336 'wgDBpassword',
 337+ 'wgDBadminuser',
 338+ 'wgDBadminpassword',
337339 'wgDBport',
338340 'wgDBserver',
339341 'wgDBtype',

Status & tagging log