r66096 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66095‎ | r66096 | r66097 >
Date:12:41, 9 May 2010
Author:ialex
Status:ok
Tags:
Comment:
* (bug 23448) MediaWiki:Summary-preview is now displayed instead of MediaWiki:Subject-preview when previewing summary
Regression from r59655.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1551,7 +1551,9 @@
15521552 if ( $isSubjectPreview )
15531553 $summary = wfMsgForContent( 'newsectionsummary', $wgParser->stripSectionName( $summary ) );
15541554
1555 - $summary = wfMsgExt( 'subject-preview', 'parseinline' ) . $sk->commentBlock( $summary, $this->mTitle, !!$isSubjectPreview );
 1555+ $message = $isSubjectPreview ? 'subject-preview' : 'summary-preview';
 1556+
 1557+ $summary = wfMsgExt( $message, 'parseinline' ) . $sk->commentBlock( $summary, $this->mTitle, $isSubjectPreview );
15561558 return Xml::tags( 'div', array( 'class' => 'mw-summary-preview' ), $summary );
15571559 }
15581560
Index: trunk/phase3/RELEASE-NOTES
@@ -156,6 +156,8 @@
157157 * (bug 23240) Add ID to namespace selector form on Special:Watchlist
158158 * The pipe | character in urls is now escaped.
159159 * (bug 23422) mp3 files can now be moved
 160+* (bug 23448) MediaWiki:Summary-preview is now displayed instead of
 161+ MediaWiki:Subject-preview when previewing summary
160162
161163 === API changes in 1.17 ===
162164 * (bug 22738) Allow filtering by action type on query=logevent

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r59655EditPage refactor and improvements....dantman07:22, 2 December 2009

Status & tagging log