r66078 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66077‎ | r66078 | r66079 >
Date:00:14, 9 May 2010
Author:mah
Status:deferred
Tags:
Comment:
update r58407 to make it clearer.
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/NewMessagesController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LiquidThreads/classes/NewMessagesController.php
@@ -174,8 +174,9 @@
175175 if ( $oldPrefCompat ) {
176176 $decodedOptions = self::decodeUserOptions( $row->user_options );
177177
178 - $wantsTalkNotification = ( ( !isset( $decodedOptions['lqtnotifytalk'] ) || is_null( $decodedOptions['lqtnotifytalk'] ) ) &&
179 - User::getDefaultOption( 'lqtnotifytalk' ) ) || $row->up_value;
 178+ $wantsTalkNotification =
 179+ ( !isset( $decodedOptions['lqtnotifytalk'] ) && User::getDefaultOption( 'lqtnotifytalk' ) )
 180+ || $row->up_value;
180181 } else {
181182 $wantsTalkNotification =
182183 ( is_null( $row->up_value ) && User::getDefaultOption( 'lqtnotifytalk' ) )

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r58407Fix PHP Notice: Undefined index: lqtnotifytalk in extensions/LiquidThreads/...siebrand21:34, 1 November 2009

Status & tagging log