r66067 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66066‎ | r66067 | r66068 >
Date:13:36, 8 May 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r66062
Modified paths:
  • /trunk/extensions/Storyboard/Storyboard.i18n.php (modified) (history)
  • /trunk/extensions/Storyboard/Storyboard.php (modified) (history)
  • /trunk/extensions/Storyboard/storyboard.js (modified) (history)

Diff [purge]

Index: trunk/extensions/Storyboard/Storyboard.i18n.php
@@ -64,6 +64,9 @@
6565 'storyboard-morecharsneeded' => '$1 more characters needed',
6666 'storyboard-charactersleft' => '$1 characters left',
6767 'storyboard-needtoagree' => 'You need to agree to the publication of your story to submit it.',
 68+ 'storyboard-done' => 'Done',
 69+ 'storyboard-working' => 'Working...',
 70+ 'storyboard-imagedeleted' => 'Image deleted',
6871
6972 // Story review
7073 'storyreview' => 'Story review',
Index: trunk/extensions/Storyboard/storyboard.js
@@ -183,7 +183,7 @@
184184 * @param action The action that needs to be performed on the story.
185185 */
186186 function stbDoStoryAction( sender, storyid, action ) {
187 - sender.innerHTML = 'Working...'; // TODO: i18n
 187+ sender.innerHTML = stbMsg( 'storyboard-working' );
188188 sender.disabled = true;
189189
190190 jQuery.getJSON( wgScriptPath + '/api.php',
@@ -197,7 +197,7 @@
198198 if ( data.storyreview ) {
199199 switch( data.storyreview.action ) {
200200 case 'publish' : case 'unpublish' : case 'hide' :
201 - sender.innerHTML = 'Done'; // TODO: i18n
 201+ sender.innerHTML = stbMsg( 'storyboard-done' );
202202 jQuery( '#story_' + data.storyreview.id ).slideUp( 'slow', function () {
203203 jQuery( this ).remove();
204204 } );
@@ -207,7 +207,7 @@
208208 stbToggeShowImage( sender, data.storyreview.id, data.storyreview.action );
209209 break;
210210 case 'deleteimage' :
211 - sender.innerHTML = 'Image deleted'; // TODO: i18n
 211+ sender.innerHTML = stbMsg( 'storyboard-imagedeleted' );
212212 jQuery( '#story_image_' + data.storyreview.id ).slideUp( 'slow', function () {
213213 jQuery( this ).remove();
214214 } );
Index: trunk/extensions/Storyboard/Storyboard.php
@@ -142,7 +142,10 @@
143143 'storyboard-needtoagree',
144144 'storyboard-anerroroccured',
145145 'storyboard-storymetadata',
146 - 'storyboard-storymetadatafrom'
 146+ 'storyboard-storymetadatafrom',
 147+ 'storyboard-done',
 148+ 'storyboard-working',
 149+ 'storyboard-imagedeleted',
147150 );
148151
149152 $data = array();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66062Implemnted JS i18n functionsjeroendedauw12:25, 8 May 2010

Status & tagging log