r66033 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r66032‎ | r66033 | r66034 >
Date:18:14, 7 May 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r66032 and proof parameter ordening in php is random
Modified paths:
  • /trunk/extensions/Awesomeness/Awesomeness.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Awesomeness/Awesomeness.php
@@ -43,7 +43,7 @@
4444 /**
4545 * Based on Svips patch at http://bug-attachment.wikimedia.org/attachment.cgi?id=7351
4646 */
47 -if ( array_key_exists( $_SERVER, 'QUERY_STRING' ) && strtolower( $_SERVER['QUERY_STRING'] ) == 'o_o' ) {
 47+if ( array_key_exists( 'QUERY_STRING', $_SERVER ) && strtolower( $_SERVER['QUERY_STRING'] ) == 'o_o' ) {
4848 header( 'Content-Type: text/plain' );
4949 die( $_SERVER['QUERY_STRING'] == 'O_o' ? 'o_O' : 'O_o' );
5050 }
\ No newline at end of file

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r66032Fixed php warningjeroendedauw18:12, 7 May 2010

Status & tagging log